-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "Tweet Now", Toggle for tweet image capabilities and improvements in tweet status. #188
Conversation
b686e45
to
e50e168
Compare
5488f03
to
dd0e7a2
Compare
@Sidsector9 I have completed the work here. can you please review it once before we request review from the team. Thanks. |
@iamdharmesh thanks for porting the feature to the Classic editor as well. I tested this with:
Works well 👍 |
@Sidsector9 @iamdharmesh sounds like this is good to merge now, correct? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with the small fix in CSS
E2E tests are broken, reported in #211 |
Co-authored-by: Max Lyuchin <[email protected]>
Description of the Change
This PR following functionalities.
1. Tweet Now Functionality
Tweet now functionality allows users to tweet any time from the post editor (Gutenberg and classic editor).
2. Add functionality for add/remove featured image from tweet
Now user can decide at post level if they want to send featured image in tweet or not.
3. Tweet status improvements
Tweet status now shows multiple logs and the status of each tweet.
Closes #179
Closes #180
Closes #181
How to test the Change
Changelog Entry
Credits
Props @iamdharmesh, @Sidsector9, @jeffpaul, (@linawiezkowiak and @oszkarnagy for the UX/Design work.)
Checklist: