Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Tweet Now", Toggle for tweet image capabilities and improvements in tweet status. #188

Merged
merged 51 commits into from
Dec 16, 2022

Conversation

Sidsector9
Copy link
Member

@Sidsector9 Sidsector9 commented Sep 28, 2022

Description of the Change

This PR following functionalities.

1. Tweet Now Functionality

Tweet now functionality allows users to tweet any time from the post editor (Gutenberg and classic editor).

Gutenberg Editor Classic Editor
Screenshot 2022-11-29 at 10 30 46 AM Screenshot 2022-11-29 at 10 31 12 AM
Screenshot 2022-11-29 at 10 30 34 AM Screenshot 2022-11-29 at 10 31 25 AM

2. Add functionality for add/remove featured image from tweet

Now user can decide at post level if they want to send featured image in tweet or not.

Gutenberg Editor Classic Editor
Screenshot 2022-11-29 at 10 36 40 AM Screenshot 2022-11-29 at 10 38 27 AM

3. Tweet status improvements

Tweet status now shows multiple logs and the status of each tweet.

Gutenberg Editor Classic Editor
Screenshot 2022-11-29 at 10 41 24 AM Screenshot 2022-11-29 at 10 41 42 AM

Closes #179
Closes #180
Closes #181

How to test the Change

  1. Configure the plugin.
  2. Test each functionality listed above thoroughly.

Changelog Entry

Added - "Tweet now" functionality.
Added - Feature toggle for adding/removing featured image from the tweet.
Changed - Improvements in Tweet status.

Credits

Props @iamdharmesh, @Sidsector9, @jeffpaul, (@linawiezkowiak and @oszkarnagy for the UX/Design work.)

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@Sidsector9 Sidsector9 self-assigned this Sep 29, 2022
@iamdharmesh iamdharmesh added this to the 1.3.0 milestone Oct 4, 2022
@iamdharmesh iamdharmesh changed the title feat/181: add retweet and toggle tweet image capabilities Add "Tweet Now", Toggle for tweet image capabilities and improvements in tweet status. Nov 29, 2022
@iamdharmesh iamdharmesh marked this pull request as ready for review November 29, 2022 05:16
@github-actions github-actions bot added the needs:code-review This requires code review. label Nov 29, 2022
@github-actions github-actions bot requested a review from iamdharmesh November 29, 2022 05:16
@iamdharmesh iamdharmesh removed their request for review November 29, 2022 05:16
@iamdharmesh
Copy link
Member

@Sidsector9 I have completed the work here. can you please review it once before we request review from the team.

Thanks.

@jeffpaul jeffpaul requested review from a team and iamdharmesh and removed request for a team November 30, 2022 17:56
@Sidsector9
Copy link
Member Author

@iamdharmesh thanks for porting the feature to the Classic editor as well. I tested this with:

  • Posts that were and were not tweeted through Classic & Gutenberg Editors using develop.
  • Posts that were and were not tweeted through Classic & Gutenberg Editors using feature branch.
  • New posts (tweet) using the feature branch.

Works well 👍

@jeffpaul
Copy link
Member

@Sidsector9 @iamdharmesh sounds like this is good to merge now, correct?

@Sidsector9 Sidsector9 requested a review from cadic December 13, 2022 05:37
cadic
cadic previously approved these changes Dec 14, 2022
Copy link
Contributor

@cadic cadic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the small fix in CSS

assets/css/admin-autoshare-for-twitter.css Outdated Show resolved Hide resolved
@cadic
Copy link
Contributor

cadic commented Dec 14, 2022

E2E tests are broken, reported in #211

@iamdharmesh iamdharmesh requested a review from cadic December 16, 2022 09:12
@iamdharmesh iamdharmesh merged commit ed274bf into develop Dec 16, 2022
@iamdharmesh iamdharmesh deleted the feat/181 branch December 16, 2022 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:code-review This requires code review.
Projects
None yet
4 participants