Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/154: Fix autotweet when autoshare enabled by default. #155

Merged
merged 1 commit into from
Apr 13, 2022
Merged

fix/154: Fix autotweet when autoshare enabled by default. #155

merged 1 commit into from
Apr 13, 2022

Conversation

iamdharmesh
Copy link
Member

@iamdharmesh iamdharmesh commented Apr 13, 2022 •
edited
Loading

Description of the Change

This PR contains changes for fixing autotweet when autoshare is enabled by default.

This bug is introduced with this change of PR #145 and this PR rollback it to fix given issue.

Closes #154

Verification Process

Manually test fix by reproducing steps given here

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Changelog Entry

Fixed - If Autoshare is enabled by default, it does not consider the post-level "Tweet this post" checkbox and always tweets.

Credits

Props @

@iamdharmesh iamdharmesh self-assigned this Apr 13, 2022
@iamdharmesh iamdharmesh requested a review from jeffpaul April 13, 2022 13:35
@jeffpaul jeffpaul added this to the 1.1.1 milestone Apr 13, 2022
@iamdharmesh iamdharmesh requested review from a team and peterwilsoncc and removed request for jeffpaul and a team April 13, 2022 13:38
@iamdharmesh iamdharmesh removed the request for review from peterwilsoncc April 13, 2022 13:53
@iamdharmesh iamdharmesh merged commit 50f34b6 into develop Apr 13, 2022
@iamdharmesh iamdharmesh deleted the fix/154 branch April 13, 2022 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sidsector9 Sidsector9 Sidsector9 approved these changes

Assignees

@iamdharmesh iamdharmesh

Labels
None yet
Projects
None yet
Milestone
1.1.1
Development

Successfully merging this pull request may close these issues.

If Autoshare enabled by default, it not consider post level "Tweet this post" checkbox and always tweet
3 participants
@iamdharmesh @Sidsector9 @jeffpaul