upkeep/148: add php8 compatibility workflow #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sidsector9
requested review from
a team and
faisal-alvi
and removed request for
a team
Sidsector9
changed the title
faisal-alvi
reviewed
Mar 25, 2022
README.md
Outdated
Comment on lines
6
to
9
|  | ||
|  | ||
|  | ||
|  |
There was a problem hiding this comment.
The paths are coming from the forked repo. Can you please change it?
faisal-alvi
requested changes
Mar 25, 2022
faisal-alvi
requested changes
Apr 1, 2022
There was a problem hiding this comment.
@Sidsector9 Code LGTM! However, I noticed,
- A "PHP Compatibility" Github Action is failing.
- The "test_php" tests are still in waiting mode. The wait is from Github and not in our control? or do we have to change something?
faisal-alvi
previously approved these changes
Apr 7, 2022
iamdharmesh
approved these changes
Apr 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
The plugin's dependency on
abraham/twitteroauth:1.2.0is not compatible with PHP 8.0. To make it compatible, I've upgraded the dependency to the immediate next version of2.0.0. Beyond 2.0.0, it drops support for PHP 7.2.phpunit/phpunitis upgraded to version 9.5.x-devSeparate Github workflows for each test:
Closes #148
Checklist:
Changelog Entry
Credits
Props @