Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable deploy excludes #7

Merged
merged 21 commits into from
Mar 30, 2019
Merged

Conversation

helen
Copy link
Collaborator

@helen helen commented Mar 28, 2019

Uses git archive to respect a .gitattributes file with export-ignore directives

Default .gitattributes file is provided/written in place - I believe the current $GITHUB_WORKSPACE is a checkout; however, I don't know that for sure so I'll be testing this shortly to check. If it's not there are two options:

  1. Do an actual checkout of the tag (I think the ref is provided in env variables during the Action) before proceeding.
  2. Parse .gitattributes into a file formatted for rsync --exclude-from. I don't know if this is a good idea, but it's an idea.

/cc @johnbillion

Fixes #1

@helen
Copy link
Collaborator Author

helen commented Mar 28, 2019

$GITHUB_WORKSPACE is not a checkout :( I was wrong, I had bad directory changes and overanalyzed my issue. :)

@helen helen merged commit 598b157 into develop Mar 30, 2019
@jeffpaul jeffpaul deleted the add/configurable-deploy-excludes branch January 8, 2021 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant