Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix update custom property pattern to also allow for single - separ ator #371

Merged
merged 5 commits into from
Feb 22, 2024

Conversation

fabiankaegy
Copy link
Member

@fabiankaegy fabiankaegy commented Feb 20, 2024

Related Issue/RFC: #

Description of the Change

I found another instance that broke the curret pattern:

--wp-admin--admin-bar--height

Alternate Designs

Possible Drawbacks

Verification Process

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.
  • I have added a changeset to my PR. See CONTRIBUTING document for instructions

Copy link

changeset-bot bot commented Feb 20, 2024

🦋 Changeset detected

Latest commit: f2c27ca

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@10up/stylelint-config Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

packages/stylelint-config/index.js Outdated Show resolved Hide resolved
@@ -0,0 +1,3 @@
:root {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Antonio-Laguna @fabiankaegy added a basic test, could you add all of the variations of the rule we shall support?

it would be great to in the future do more unit testing of our config.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@nicholasio nicholasio merged commit ae04aa8 into develop Feb 22, 2024
6 of 7 checks passed
@nicholasio nicholasio deleted the fix/custom-property-pattern branch February 22, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants