Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust markup for radio and checkbox fields to match WordPress Core #92

Closed
wants to merge 5 commits into from
Closed

Adjust markup for radio and checkbox fields to match WordPress Core #92

wants to merge 5 commits into from

Conversation

claytoncollie
Copy link
Contributor

Description of the Change

Addresses #41 to fix the alignment of checkbox and radio fields in the wp-admin. Radios and checkboxes now follow the same markup as WordPress Core.

Benefits

Accessibility and keyboard usability of the admin pages should be a little cleaner with these changes.

Possible Drawbacks

Breaking the settings fields.

Verification Process

  • How did you verify that all new functionality works as expected?

Installed the plugin on a local instance, made my changes and saved each settings field multiple times:

Disable Gutenberg - https://tenup.test/wp-admin/options-writing.php

Enable Password Protection - https://tenup.test/wp-admin/options-writing.php

Enable Support Monitor - https://tenup.test/wp-admin/options-general.php

Production Environment - https://tenup.test/wp-admin/options-general.php

And also for multisite - https://tenup.test/wp-admin/network/settings.php

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.

Changelog Entry

Changed admin markup for Disable Gutenberg, Enable Password Protection, Enable Support Monitor, and Production Environment

@jeffpaul jeffpaul added this to the 1.9.2 milestone Sep 28, 2022
@claytoncollie claytoncollie closed this by deleting the head repository Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants