Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

we need to set_password after save the user otherwise it'll save the raw_password in db. (Sourcery refactored) #135

Merged
merged 3 commits into from
Apr 22, 2022

Conversation

sourcery-ai[bot]
Copy link
Contributor

@sourcery-ai sourcery-ai bot commented Apr 22, 2022

Pull Request #129 refactored by Sourcery.

Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it.

To incorporate these changes, you can either:

  1. Merge this Pull Request instead of the original, or

  2. Ask your contributor to locally incorporate these commits and push them to
    the original Pull Request

    Incorporate changes via command line
    git fetch https://github.com/101Loop/drf-user pull/129/head
    git merge --ff-only FETCH_HEAD
    git push

NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Help us improve this pull request!

"otp": _("OTP sending failed {}".format(sentotp_email["message"]))
}
message["email"] = {"otp": _(f'OTP sending failed {sentotp_email["message"]}')}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function OTPLoginView.post refactored with the following changes:

@sourcery-ai
Copy link
Contributor Author

sourcery-ai bot commented Apr 22, 2022

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.17%.

Quality metrics Before After Change
Complexity 7.33 ⭐ 7.27 ⭐ -0.06 👍
Method Length 76.67 🙂 76.92 🙂 0.25 👎
Working memory 9.24 🙂 9.22 🙂 -0.02 👍
Quality 61.72% 🙂 61.89% 🙂 0.17% 👍
Other metrics Before After Change
Lines 279 279 0
Changed files Quality Before Quality After Quality Change
drf_user/views.py 61.72% 🙂 61.89% 🙂 0.17% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
drf_user/views.py OTPLoginView.post 15 🙂 245 ⛔ 10 😞 41.48% 😞 Try splitting into smaller methods. Extract out complex expressions
drf_user/views.py OTPView.post 11 🙂 142 😞 13 😞 47.97% 😞 Try splitting into smaller methods. Extract out complex expressions
drf_user/views.py LoginView.post 0 ⭐ 93 🙂 13 😞 64.78% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@sumit4613 sumit4613 merged commit 932f219 into master Apr 22, 2022
@sumit4613 sumit4613 deleted the sourcery/pull-129 branch April 22, 2022 15:35
sumit4613 added a commit to zhiwehu/drf-user that referenced this pull request Apr 22, 2022
…ave the raw_password in db. (Sourcery refactored) (101Loop#135)"

This reverts commit 932f219.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants