Fix new EF Core warning

See dotnet/efcore#17471 (comment)
0xced · Mar 3, 2020 · a3d484a · a3d484a
1 parent 8f84b7b
commit a3d484a
Showing 1 changed file with 13 additions and 2 deletions.
diff --git a/source/Web/Database/NugetPackageConfiguration.cs b/source/Web/Database/NugetPackageConfiguration.cs
@@ -5,6 +5,7 @@
 using ICanHasDotnetCore.NugetPackages;
 using ICanHasDotnetCore.Plumbing;
 using Microsoft.EntityFrameworkCore;
+using Microsoft.EntityFrameworkCore.ChangeTracking;
 using Microsoft.EntityFrameworkCore.Metadata.Builders;
 using Microsoft.EntityFrameworkCore.Storage.ValueConversion;
 using NuGet.Versioning;
@@ -13,6 +14,14 @@ namespace ICanHasDotnetCore.Web.Database
 {
     public class NugetPackageConfiguration : IEntityTypeConfiguration<NugetPackage>
     {
+        private static ValueComparer<IReadOnlyList<T>> CreateIReadOnlyListComparer<T>()
+        {
+            // Adapted from https://github.com/dotnet/efcore/issues/17471#issuecomment-526330450
+            return new ValueComparer<IReadOnlyList<T>>(
+                (c1, c2) => c1.SequenceEqual(c2),
+                c => c.Aggregate(0, (a, v) => HashCode.Combine(a, v.GetHashCode())));
+        }
+
         public void Configure(EntityTypeBuilder<NugetPackage> builder)
         {
             var dependenciesConverter = new ValueConverter<IReadOnlyList<string>, string>
@@ -34,8 +43,10 @@ public void Configure(EntityTypeBuilder<NugetPackage> builder)
             builder.Property(e => e.Version).HasConversion(versionConverter);
             builder.Property(e => e.SupportType).HasConversion<string>();
             builder.Property(e => e.ProjectUrl);
-            builder.Property(e => e.Dependencies).HasConversion(dependenciesConverter);
-            builder.Property(e => e.Frameworks).HasConversion(frameworksConverter);
+            builder.Property(e => e.Dependencies).HasConversion(dependenciesConverter)
+                .Metadata.SetValueComparer(CreateIReadOnlyListComparer<string>());
+            builder.Property(e => e.Frameworks).HasConversion(frameworksConverter)
+                .Metadata.SetValueComparer(CreateIReadOnlyListComparer<FrameworkName>());
         }
     }
 }