Skip to content
This repository has been archived by the owner on Dec 15, 2023. It is now read-only.

Detach plugin #69

Merged
merged 27 commits into from
Apr 6, 2022
Merged

Detach plugin #69

merged 27 commits into from
Apr 6, 2022

Conversation

badurinantun
Copy link
Contributor

@badurinantun badurinantun commented Apr 5, 2022 •
edited by FabijanC
Loading

Usage changes

None

Dev changes

  • Removed example repository
  • Added Cairo tests contracts and compile script
  • Added Account artifacts
  • Removed extra installation of Cairo (still installed as a poetry dependency)
  • Created Hardhat config for Solidity compiling and L1 testnet

badurinantun and others added 19 commits March 29, 2022 14:35
@badurinantun badurinantun self-assigned this Apr 5, 2022
FabijanC
FabijanC suggested changes Apr 6, 2022
View reviewed changes
Copy link
Collaborator

@FabijanC FabijanC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there have been new subdirectories introduced containing python code, can you ensure that they are subject to linting?

test/util.py Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
scripts/install_dev_tools.sh Show resolved Hide resolved
scripts/compile_contracts.sh Outdated Show resolved Hide resolved
scripts/compile_contracts.sh Outdated Show resolved Hide resolved
scripts/compile_contracts.sh Outdated Show resolved Hide resolved
scripts/compile_contracts.sh Outdated Show resolved Hide resolved
test/test_account.py Show resolved Hide resolved
test/test_account.py Outdated Show resolved Hide resolved
test/test_account.py Outdated Show resolved Hide resolved
@badurinantun badurinantun requested a review from FabijanC April 6, 2022 13:43
@FabijanC FabijanC merged commit 213f1dc into master Apr 6, 2022
@FabijanC FabijanC deleted the detach-plugin branch April 6, 2022 14:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@FabijanC FabijanC Awaiting requested review from FabijanC

Assignees

@badurinantun badurinantun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@badurinantun @FabijanC