Skip to content
This repository has been archived by the owner on Dec 15, 2023. It is now read-only.

Estimate fee #62

Merged
merged 10 commits into from
Mar 24, 2022
Merged

Estimate fee #62

merged 10 commits into from
Mar 24, 2022

Conversation

FabijanC
Copy link
Collaborator

@FabijanC FabijanC commented Mar 23, 2022

Usage changes

  • Introduce fee estimation endpoint.
  • Check if max_fee too low in invokes and fail if so.

Dev changes

  • Test account+fee behavior through a test in the example repository.
  • Use cp instead of mv for handling custom hardhat config files.
  • Remove set_origin, make origin public

TODO

  • Find out if calls also require fee check (and not just invokes)
    • Answer: they don't.

@FabijanC FabijanC requested review from dribeiro-ShardLabs and removed request for dribeiro-ShardLabs March 23, 2022 13:54
@badurinantun badurinantun self-requested a review March 23, 2022 15:46
starknet_devnet/starknet_wrapper.py Show resolved Hide resolved
starknet_devnet/starknet_wrapper.py Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
@FabijanC FabijanC merged commit ab69a92 into master Mar 24, 2022
@FabijanC FabijanC deleted the estimate-fee branch March 24, 2022 12:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants