Skip to content
This repository has been archived by the owner on Dec 15, 2023. It is now read-only.

Fix get_state_update when forking #525

Merged
merged 1 commit into from
Sep 4, 2023
Merged

Fix get_state_update when forking #525

merged 1 commit into from
Sep 4, 2023

Conversation

FabijanC
Copy link
Collaborator

@FabijanC FabijanC commented Sep 4, 2023 •
edited
Loading

Usage related changes

  • When forking and getting state update of e.g. block with number 0, it would fail due to a bug. This is now fixed.

Development related changes

  • Improve return type of get_state_update in origin.py (use BlockStateUpdate instead of dict).

Checklist:

  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/lint.sh
  • Performed code self-review
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Documented the changes
  • Linked the issues which this PR resolves
  • Updated the tests
  • All tests are passing - ./scripts/test.sh

@FabijanC FabijanC marked this pull request as ready for review September 4, 2023 13:32
@FabijanC FabijanC requested a review from mikiw September 4, 2023 13:32
@FabijanC FabijanC merged commit b9bcd60 into master Sep 4, 2023
@FabijanC FabijanC deleted the fix-get-state-update branch September 4, 2023 14:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mikiw mikiw mikiw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FabijanC @mikiw