Skip to content
This repository has been archived by the owner on Dec 15, 2023. It is now read-only.

Support starknet_simulateTransactions #524

Merged
merged 1 commit into from
Sep 1, 2023
Merged

Support starknet_simulateTransactions #524

merged 1 commit into from
Sep 1, 2023

Conversation

FabijanC
Copy link
Collaborator

@FabijanC FabijanC commented Sep 1, 2023 •
edited
Loading

Usage related changes

Development related changes

  • Use parametrization in rpc simulation tests (parametrized simulation method)
  • Add dummy_consume_unused to deal with unused background devnet fixture

Checklist:

  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/lint.sh
  • Performed code self-review
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Documented the changes
  • Linked the issues which this PR resolves
  • Updated the tests
  • All tests are passing - ./scripts/test.sh

@FabijanC FabijanC requested a review from mikiw September 1, 2023 15:30
mikiw
mikiw approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@mikiw mikiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks legit

@FabijanC FabijanC marked this pull request as ready for review September 1, 2023 15:41
@FabijanC FabijanC merged commit e0b7871 into master Sep 1, 2023
@FabijanC FabijanC deleted the simulateTransactions branch September 1, 2023 15:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mikiw mikiw mikiw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JSON-RPC: starknet_simulateTransactions should be supported
2 participants
@FabijanC @mikiw