Skip to content
This repository has been archived by the owner on Dec 15, 2023. It is now read-only.

Adapt to Starknet 0.12.1 #517

Merged
merged 5 commits into from
Aug 9, 2023
Merged

Adapt to Starknet 0.12.1 #517

merged 5 commits into from
Aug 9, 2023

Conversation

FabijanC
Copy link
Collaborator

@FabijanC FabijanC commented Aug 8, 2023

Usage related changes

  • Adapt to Starknet 0.12.1

Development related changes

  • Replace cairo-lang 0.12.1a0 with 0.12.1
  • Refactor block loading due to a bug in cairo-lang 0.12.1 which prevents aborted blocks from being loaded via StarknetBlock.load
  • Refactor block testing:
    • Expected slight testing speed up since the HTTP call is done directly, not via Starknet CLI - couldn't rely on FeederGatewayClient class because it would do parsing and
    • Remove the parse parameter from get_block util - it was always True except in one case which was refactored

Checklist:

  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/lint.sh
  • Performed code self-review
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Documented the changes
  • Linked the issues which this PR resolves
  • Updated the tests
  • All tests are passing - ./scripts/test.sh

@FabijanC FabijanC requested a review from mikiw August 8, 2023 15:23
@FabijanC FabijanC marked this pull request as ready for review August 8, 2023 15:23
Copy link
Contributor

@mikiw mikiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks legit

@FabijanC FabijanC merged commit 916609b into master Aug 9, 2023
@FabijanC FabijanC deleted the adapt-0.12.1 branch August 9, 2023 09:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants