Skip to content
This repository has been archived by the owner on Dec 15, 2023. It is now read-only.

Refactor estimation and simulation #506

Merged
merged 3 commits into from
Jun 16, 2023
Merged

Refactor estimation and simulation #506

merged 3 commits into from
Jun 16, 2023

Conversation

FabijanC
Copy link
Collaborator

@FabijanC FabijanC commented Jun 16, 2023 •
edited
Loading

Usage related changes

N/A

Development related changes

  • Close Fix calculate_traces_and_fees #498
    • StarknetWrapper::calculate_traces_and_fees now doesn't have the responsibility of extracting the tx types
    • RPC changes:
      • Fix typing
      • simulateTransaction and estimateFee now using a common method

Checklist:

  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/lint.sh
  • Performed code self-review
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Documented the changes
  • Linked the issues which this PR resolves
  • Updated the tests
  • All tests are passing - ./scripts/test.sh

@FabijanC FabijanC merged commit 054e2ec into master Jun 16, 2023
@FabijanC FabijanC deleted the refactor-estimate-simulate branch June 16, 2023 12:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix calculate_traces_and_fees
1 participant
@FabijanC