Skip to content
This repository has been archived by the owner on Dec 15, 2023. It is now read-only.

Renamed transaction param for rpc simulateTransactions #499

Merged
merged 2 commits into from
Jun 14, 2023
Merged

Renamed transaction param for rpc simulateTransactions #499

merged 2 commits into from
Jun 14, 2023

Conversation

ivpavici
Copy link
Contributor

@ivpavici ivpavici commented Jun 13, 2023 •
edited by FabijanC
Loading

Usage related changes

  • Renamed transaction param to transactions for rpc simulateTransactions, because this name will change in the rpc spec

Development related changes

N/A

Checklist:

  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/lint.sh
  • Performed code self-review
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Documented the changes
  • Linked the issues which this PR resolves
  • Updated the tests
  • All tests are passing - ./scripts/test.sh

mikiw
mikiw approved these changes Jun 14, 2023
View reviewed changes
Copy link
Contributor

@mikiw mikiw left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks legit to me but let's wait for an updated version of the specification before merging to master.

@ivpavici
Copy link
Contributor Author

ivpavici commented Jun 14, 2023 •
edited
Loading

Looks legit to me but let's wait for an updated version of the specification before merging to master.

Made a PR on specs:
starkware-libs/starknet-specs#103

FabijanC
FabijanC approved these changes Jun 14, 2023
View reviewed changes
Copy link
Collaborator

@FabijanC FabijanC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, we should merge this ASAP because others have already implemented this change (despite not being a part of an official specification).

@FabijanC FabijanC merged commit 4a8d028 into master Jun 14, 2023
@FabijanC FabijanC deleted the ivpavici_simulate_transactions branch June 14, 2023 09:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@FabijanC FabijanC FabijanC approved these changes

@mikiw mikiw mikiw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ivpavici @mikiw @FabijanC