Skip to content
This repository has been archived by the owner on Dec 15, 2023. It is now read-only.

Improve docs on Cairo 1 support #491

Merged
merged 3 commits into from
May 31, 2023
Merged

Improve docs on Cairo 1 support #491

merged 3 commits into from
May 31, 2023

Conversation

FabijanC
Copy link
Collaborator

@FabijanC FabijanC commented May 31, 2023 •
edited
Loading

Usage related changes

  • Improves docs
    • Adds motivation for the compilation Devnet does
    • Replaces recompiler with compiler because it was confusing people
  • Improves compilation error message

Development related changes

N/A

Checklist:

  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/lint.sh
  • Performed code self-review
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Documented the changes
  • Linked the issues which this PR resolves
  • All tests are passing - ./scripts/test.sh

@FabijanC FabijanC requested a review from mikiw May 31, 2023 09:03
@mikiw mikiw marked this pull request as ready for review May 31, 2023 10:08
mikiw
mikiw approved these changes May 31, 2023
View reviewed changes
starknet_devnet/compiler.py Show resolved Hide resolved
@FabijanC FabijanC merged commit a8f56de into master May 31, 2023
@FabijanC FabijanC deleted the fix-cairo1-docs branch May 31, 2023 12:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mikiw mikiw mikiw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FabijanC @mikiw