Skip to content
This repository has been archived by the owner on Dec 15, 2023. It is now read-only.

bugfix for __postman_wrapper on init #489

Merged
merged 6 commits into from
May 29, 2023
Merged

bugfix for __postman_wrapper on init #489

merged 6 commits into from
May 29, 2023

Conversation

mikiw
Copy link
Contributor

@mikiw mikiw commented May 29, 2023 •
edited
Loading

Usage related changes

  • bugfix for flush endpoint call without previous call of load_l1_messaging_contract

Checklist:

  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/lint.sh
  • Performed code self-review
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Documented the changes
  • Linked the issues which this PR resolves
  • Updated the tests
  • All tests are passing - ./scripts/test.sh

@mikiw mikiw linked an issue May 29, 2023 that may be closed by this pull request
ValueError when calling postman flush #485
Closed
2 tasks
@mikiw mikiw requested a review from FabijanC May 29, 2023 14:07
FabijanC
FabijanC suggested changes May 29, 2023
View reviewed changes
Copy link
Collaborator

@FabijanC FabijanC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed: can be a simple test which just attempts flushing before anything has been done previously postman-wise. And we should just assert nothing has failed. Maybe we don't even have to load anything in this new test.

starknet_devnet/postman_wrapper.py Outdated Show resolved Hide resolved
starknet_devnet/starknet_wrapper.py Outdated Show resolved Hide resolved
@mikiw
Copy link
Contributor Author

mikiw commented May 29, 2023

I added new test

@mikiw mikiw merged commit e49ea5b into master May 29, 2023
@FabijanC FabijanC deleted the l1l2-flush-fix branch May 29, 2023 16:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@FabijanC FabijanC FabijanC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ValueError when calling postman flush
2 participants
@mikiw @FabijanC