Skip to content
This repository has been archived by the owner on Dec 15, 2023. It is now read-only.

Fix for missing __latest_state at the initialization of StarknetWrapper #484

Merged
merged 1 commit into from
May 31, 2023
Merged

Fix for missing __latest_state at the initialization of StarknetWrapper #484

merged 1 commit into from
May 31, 2023

Conversation

mikiw
Copy link
Contributor

@mikiw mikiw commented May 26, 2023 •
edited
Loading

Usage related changes

  • bugfix for missing __latest_state at the initialization of StarknetWrapper

Checklist:

  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/lint.sh
  • Performed code self-review
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Documented the changes
  • Linked the issues which this PR resolves
  • Updated the tests
  • All tests are passing - ./scripts/test.sh

@mikiw mikiw linked an issue May 26, 2023 that may be closed by this pull request
Getting error when querying JSON RPC #477
Closed
2 tasks
@mikiw mikiw changed the title Update starknet_wrapper.py Fix for missing __latest_state at the initialization of StarknetWrapper May 26, 2023
@mikiw mikiw requested a review from FabijanC May 26, 2023 10:51
FabijanC
FabijanC reviewed May 26, 2023
View reviewed changes
Copy link
Collaborator

@FabijanC FabijanC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well looks good, but I can't approve this as we are still puzzled as to why this hasn't been an issue all this time?

@FabijanC
Copy link
Collaborator

Ok, I've had a change of heart, let's merge it.

@mikiw mikiw merged commit fc0026a into master May 31, 2023
@mikiw mikiw deleted the rpc-latest-state-problem branch May 31, 2023 10:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@FabijanC FabijanC FabijanC left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Getting error when querying JSON RPC
2 participants
@mikiw @FabijanC