Skip to content
This repository has been archived by the owner on Dec 15, 2023. It is now read-only.

starknet_devnet/compiler.py: fix error messages #479

Merged
merged 1 commit into from
May 22, 2023

Conversation

cfal
Copy link
Contributor

@cfal cfal commented May 22, 2023

Usage related changes

this was discovered due to #478

errors aren't displayed correctly due to typing errors when concatenating error messages:

AssertionError: StarknetPluginError: Declaring contract failed: unsupported operand type(s) for +: 'PermissionError' and 'str'

also fixed the following exception message in the StarkException clause because message is typed Optional[str]

Checklist:

  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/lint.sh
  • Performed code self-review
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Documented the changes
  • Linked the issues which this PR resolves
  • Updated the tests
  • All tests are passing - ./scripts/test.sh

starknet_devnet/compiler.py Outdated Show resolved Hide resolved
@cfal cfal force-pushed the fix-error-str branch from 754be51 to 872197d Compare May 22, 2023 08:11
@FabijanC FabijanC merged commit 5d47d41 into 0xSpaceShard:master May 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants