Skip to content
This repository has been archived by the owner on Dec 15, 2023. It is now read-only.

Support custom sierra compiler #471

Merged
merged 5 commits into from
May 15, 2023
Merged

Support custom sierra compiler #471

merged 5 commits into from
May 15, 2023

Conversation

FabijanC
Copy link
Collaborator

@FabijanC FabijanC commented May 12, 2023

Usage related changes

Development related changes

  • Make CustomContractClassCompiler an abstract class with two derived classes:
    • ManifestContractClassCompiler for compiler relying on the provided manifest file path
    • BinaryContractClassCompiler for compiler relying on the provided executable binary path

Checklist:

  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/lint.sh
  • Performed code self-review
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Documented the changes
  • Linked the issues which this PR resolves
  • Updated the tests
  • All tests are passing - ./scripts/test.sh
  • Tested Docker compatibility

@FabijanC FabijanC requested a review from mikiw May 15, 2023 10:49
@FabijanC FabijanC marked this pull request as ready for review May 15, 2023 10:51
test/test_compiler.py Show resolved Hide resolved
@FabijanC FabijanC merged commit d6157e0 into master May 15, 2023
@FabijanC FabijanC deleted the sierra-path-option branch May 15, 2023 11:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants