Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create devnet specific endpoints #468

Closed
wants to merge 2 commits into from

Conversation

mubarak23
Copy link

@mubarak23 mubarak23 commented May 14, 2024

Usage related changes

Checklist:

Copy link
Contributor

@FabijanC FabijanC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this PR is work in progress, please consider converting it to draft. Sorry to see that you didn't like the default PR checklist, it's very useful. Note that there are conflicts with main after #469.

@mubarak23
Copy link
Author

If this PR is work in progress, please consider converting it to draft. Sorry to see that you didn't like the default PR checklist, it's very useful. Note that there are conflicts with main after #469.

i will look into it and fix it

@mubarak23
Copy link
Author

@FabijanC this is the PR, kindly review

Copy link
Contributor

@FabijanC FabijanC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wrong. The idea is to make existing functionality (like minting) available via the /rpc endpoint, not introduce new endpoints. So, not to introduce /devnet_mint, but to have /rpc accept:

POST /rpc
{
  "method": "devnet_mint",
  ...
}

This is explained in #463

@mubarak23
Copy link
Author

This is wrong. The idea is to make existing functionality (like minting) available via the /rpc endpoint, not introduce new endpoints. So, not to introduce /devnet_mint, but to have /rpc accept:

POST /rpc
{
  "method": "devnet_mint",
  ...
}

This is explained in #463

i see, i will change it

@FabijanC
Copy link
Contributor

@mubarak23 Any progress? Or do you want to be unassigned?

@mubarak23
Copy link
Author

@mubarak23 Any progress? Or do you want to be unassigned?

Yaah, please unsigned and assigned it to someone.

Thank you

@FabijanC FabijanC closed this May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants