This repository has been archived by the owner on Dec 15, 2023. It is now read-only.
Fix failing isinstance checks in syscalls with Rust VM #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmoletta
changed the title
FabijanC
changed the title
FabijanC
reviewed
May 11, 2023
FabijanC
approved these changes
May 11, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug causing certain syscalls to fail when running with cairo_rs_py. This bug was first discovered by running a contract that emits an event. It is caused by an isinstance check in the method
SyscallHandlerBase._get_felt_rangethat failed due to cairo_rs_py and cairo-lang using a similar but differentRelocatableValueclass.In order to fix this, the method
SyscallHandlerBase._get_felt_rangewas overriden in the patch so that it usescairo_rs_py.RelocatableValuefor its isinstance checks.Checklist:
./scripts/format.sh./scripts/lint.sh./scripts/test.sh