Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dump load improvements #310

Merged
merged 40 commits into from
Jan 22, 2024
Merged

Dump load improvements #310

merged 40 commits into from
Jan 22, 2024

Conversation

mikiw
Copy link
Contributor

@mikiw mikiw commented Jan 11, 2024 •
edited
Loading

Usage related changes

  • HTTP dump endpoint requires specification of dump mode otherwise, dump events will not be stored

Development related changes

  • From now on we store endpoint events like CreateBlock, SetTime, IncreaseTime, and transactions as broadcasted transactions in Starknet.dump_events to re-execute

Checklist:

  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/clippy_check.sh
  • No unused dependencies - ./scripts/check_unused_deps.sh
  • Performed code self-review
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Documented the changes
  • Linked the issues which this PR resolves
  • Checked the TODO section in README.md if this PR resolves it
  • Updated the tests
  • All tests are passing - cargo test

@mikiw mikiw marked this pull request as draft January 11, 2024 10:51
@mikiw
Copy link
Contributor Author

mikiw commented Jan 15, 2024 •
edited
Loading

although all tests are passing now I still need to add some new tests and features like set/increase time

@mikiw mikiw linked an issue Jan 16, 2024 that may be closed by this pull request
Improve the dump and load feature #237
Closed
@mikiw mikiw marked this pull request as ready for review January 17, 2024 14:43
@mikiw mikiw requested a review from FabijanC January 17, 2024 15:23
FabijanC
FabijanC requested changes Jan 18, 2024
View reviewed changes
@mikiw mikiw linked an issue Jan 22, 2024 that may be closed by this pull request
Sending ctrl+c and sleeping could be unified #316
Closed
@mikiw mikiw requested a review from FabijanC January 22, 2024 14:07
FabijanC
FabijanC approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@FabijanC FabijanC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. You just need to merge 'main' again once #318 is merged

@mikiw mikiw merged commit e3a0d07 into main Jan 22, 2024
@mikiw mikiw deleted the dump-load-improvements branch January 22, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabijanC FabijanC FabijanC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sending ctrl+c and sleeping could be unified Improve the dump and load feature
2 participants
@mikiw @FabijanC