Skip to content
This repository has been archived by the owner on Dec 15, 2023. It is now read-only.

Refactor StarknetWrapper and TransactionWrapper #27

Merged
merged 6 commits into from
Jan 12, 2022
Merged

Conversation

FabijanC
Copy link
Collaborator

Usage

  • No change in the way users will see Devnet (actually depends on how we look at the state update not being run after unsuccessful deployments).

Dev

  • StarknetWrapper:
    • __update_state was called in StarknetWrapper.deploy regardless of deployment success - this was probably wrong.
    • Separate call and invoke.
    • Make invoke transactions follow the same principle so far used by deploy transactions (push try-except logic from server to StarknetWrapper).
  • TransactionWrapper:
    • Tx hash is taken from internal tx objects (tx wrappers no longer require Starknet state/config)
    • Make more use of super constructor.
    • Eliminate generate_transaction.
    • Use helper classes (Details classes) instead of **kwargs.

@FabijanC FabijanC merged commit 880370e into master Jan 12, 2022
@FabijanC FabijanC deleted the refactor branch January 12, 2022 10:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants