This repository has been archived by the owner on Dec 15, 2023. It is now read-only.
Parametrize block number test #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This version seems to work but further refactoring is needed. Function fixture_run_devnet_in_background should be referenced and tests should check if --lite-mode works and hashes are 0x0+. [skip ci]
Extract run_devnet_in_background to new conftest.py file
FabijanC
approved these changes
Aug 30, 2022
internnos
pushed a commit
to internnos/starknet-devnet
that referenced
this pull request
Aug 30, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage related changes
Now we can run only one parameterized test which is test_block_number_incremented (resolves #234).
Development related changes
There is a new conftest.py file with fixture_run_devnet_in_background that was moved one directory up.
Checklist:
./scripts/format.sh./scripts/lint.sh