Skip to content
This repository has been archived by the owner on Dec 15, 2023. It is now read-only.

Fix: Fee token and Account improvements #203

Merged
merged 6 commits into from
Aug 3, 2022
Merged

Conversation

tabaktoni
Copy link
Contributor

@tabaktoni tabaktoni commented Aug 2, 2022

Development related changes

Restructure fee_token and account

  • created Accounts class for dealing with accounts
  • cleaned state
  • OOP improvement for fee_token extracted from the wrapper
  • OOP improvement for account extracted from the wrapper
  • wrapper 'starknet' made public accessible

Not perfect (as starknet_wrapper is now a constructor parameter) but I think it has good direction.
Now both fee_token and account have similar structure and implementation.

Checklist:

  • No linter errors
  • Performed a self-review of the code
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Documented the changes
  • Linked the issues which this PR resolves
  • Updated the tests
  • All tests are passing

@tabaktoni tabaktoni requested a review from FabijanC August 2, 2022 10:35
starknet_devnet/fee_token.py Outdated Show resolved Hide resolved
starknet_devnet/fee_token.py Outdated Show resolved Hide resolved
@tabaktoni tabaktoni marked this pull request as ready for review August 2, 2022 14:36
@tabaktoni tabaktoni requested a review from FabijanC August 2, 2022 14:39
@tabaktoni tabaktoni changed the title Fix: Fee token implementation separated from the wrapper Fix: Fee token and Account improvements Aug 2, 2022
@tabaktoni tabaktoni self-assigned this Aug 2, 2022
starknet_devnet/starknet_wrapper.py Outdated Show resolved Hide resolved
@tabaktoni tabaktoni requested a review from FabijanC August 3, 2022 15:48
@FabijanC FabijanC merged commit 7aa1ff7 into master Aug 3, 2022
@FabijanC FabijanC deleted the ttabak/0.2.7/fee-token branch August 3, 2022 16:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants