Skip to content
This repository has been archived by the owner on Dec 15, 2023. It is now read-only.

Add dump path check #182

Merged
merged 3 commits into from
Jul 15, 2022
Merged

Add dump path check #182

merged 3 commits into from
Jul 15, 2022

Conversation

FabijanC
Copy link
Collaborator

@FabijanC FabijanC commented Jul 15, 2022

Usage related changes

  • Check if the directory of the dump paths exists (when specified through CLI and through HTTP).

Development related changes

  • Alphabetically sort imports in some files.
  • Change dump tests to explicitly check for status code == 1
  • Change order of set_dump_options and generate_accounts so that failure in case of an invalid dump path happens sooner.

Checklist:

  • No linter errors
  • Performed a self-review of the code
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Documented the changes
  • Updated the tests
  • All tests are passing

@FabijanC FabijanC requested a review from tabaktoni July 15, 2022 15:34
@FabijanC FabijanC merged commit 4f1ce69 into master Jul 15, 2022
@FabijanC FabijanC deleted the fix-dump-path-check branch July 15, 2022 16:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants