Skip to content
This repository has been archived by the owner on Dec 15, 2023. It is now read-only.

Fix linting #179

Merged
merged 1 commit into from
Jul 14, 2022
Merged

Fix linting #179

merged 1 commit into from
Jul 14, 2022

Conversation

FabijanC
Copy link
Collaborator

Usage related changes

None

Development related changes

  • Change the name of debug mode script (use underscores to conform to other scripts).
  • Introduce new linting script (scripts/lint.sh):
    • Reach all .py files
    • Apply linter fixes where registered (support/assertions.py)
    • Note to devs: update your .git/hooks/pre-commit script

Checklist:

  • No linter errors
  • Performed a self-review of the code
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Documented the changes
  • All tests are passing

@FabijanC FabijanC requested a review from tabaktoni July 13, 2022 14:50
tabaktoni
tabaktoni reviewed Jul 14, 2022
View reviewed changes
scripts/lint.sh

set -e

poetry run pylint $(git ls-files '*.py')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smart solution

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, john is really smart, had to scroll all the way to the third answer: https://stackoverflow.com/a/63044665

@FabijanC FabijanC merged commit c50e945 into master Jul 14, 2022
@FabijanC FabijanC deleted the fix-lint branch July 14, 2022 12:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tabaktoni tabaktoni tabaktoni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FabijanC @tabaktoni