Skip to content
This repository has been archived by the owner on Dec 15, 2023. It is now read-only.

Mint improve #149

Merged
merged 5 commits into from
Jul 5, 2022
Merged

Mint improve #149

merged 5 commits into from
Jul 5, 2022

Conversation

FabijanC
Copy link
Collaborator

@FabijanC FabijanC commented Jul 5, 2022

Usage related changes

  • Change tx_hash from mint response from int to hex string.
  • Document lite minting.
  • Add input validation for minting.

Development related changes

  • Improve testing
  • Add invalid input tests
  • I reused old code for input validation, but had to slightly modify timestamp tests because of that (Time -> time)
  • Replace single with double qoutes

Checklist:

  • No linter errors
  • Performed a self-review of the code
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Documented the changes
  • Updated the tests
  • All tests are passing

@FabijanC FabijanC requested a review from tabaktoni July 5, 2022 11:37
Copy link
Contributor

@tabaktoni tabaktoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Great job

  • Do you think it will be good to export extract_positive & extract_hex_string to util.py same as custom_int formater/validator? Or place it at the top of the file before all routes?

@FabijanC FabijanC merged commit d07d5d2 into master Jul 5, 2022
@FabijanC FabijanC deleted the mint-improve branch July 5, 2022 13:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants