Skip to content
This repository has been archived by the owner on Dec 15, 2023. It is now read-only.

Partially update rpc endpoint to version 0.15.0 #142

Merged
merged 10 commits into from
Jun 30, 2022

Conversation

cptartur
Copy link
Contributor

Usage related changes

Updated RPC endpoints to partially match 0.15 specs:

  • added contract class related methods
  • added support for declare transactions
  • updated return types for existing methods

Not added:

  • Some methods from the spec
  • "pending", "latest" block support in most methods
  • Nonce related parameters always return empty results (no support in cairo-lang/devnet afaik as of now)

Development related changes

None

Checklist:

  • Performed a self-review of the code
  • Rebased to the base branch
  • Documented the changes
  • Updated the tests
  • All tests are passing

Copy link
Collaborator

@FabijanC FabijanC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • README.md needs to be updated (API version).
  • I don't understand the observation about nonces.
  • In the meantime, specifications have been updated to v0.16.0 😃 .

starknet_devnet/blueprints/rpc.py Show resolved Hide resolved
test/declare.json Outdated Show resolved Hide resolved
test/test_rpc_endpoints.py Show resolved Hide resolved
test/test_rpc_endpoints.py Outdated Show resolved Hide resolved
starknet_devnet/blueprints/rpc.py Outdated Show resolved Hide resolved
starknet_devnet/blueprints/rpc.py Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
starknet_devnet/blueprints/rpc.py Outdated Show resolved Hide resolved
@cptartur
Copy link
Contributor Author

  • Readme has been updated.
  • What I meant is that the RPC added some kind of native support for "nonces", but I don't think it's possible to support it right now. It has a new endpoint getNonce endpoint. Also nonces field has been added to block state update, and this will always return an empty list for now, because I don't think there's a way to support it yet.
  • I've seen 0.16 is out but i think it'll be better to have it as a separate PR.

@FabijanC FabijanC merged commit 3ba882d into 0xSpaceShard:master Jun 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants