This repository has been archived by the owner on Dec 15, 2023. It is now read-only.
Update dependencies #109
Merged
Update dependencies #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did using Devnet without these dependency updates cause you problems? |
|
Not at all. It is an optional patch :) |
Turns out it's not an optional patch: https://app.circleci.com/pipelines/github/Shard-Labs/starknet-devnet/744/workflows/6a339d44-ebc1-436c-a2c1-289e861a4c82/jobs/960 Basically your earlier PR #108 should have included the change to poetry.lock as well. Without it, the image building process could not be executed. Image building is only done on master, so even testing your other branch before merging it wouldn't have helped. Conclusion: I'm merging this PR as well (I successfully built the image locally using poetry.lock from this PR) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist: