Skip to content
This repository has been archived by the owner on Dec 15, 2023. It is now read-only.

Use types #104

Merged
merged 11 commits into from
May 18, 2022
Merged

Use types #104

merged 11 commits into from
May 18, 2022

Conversation

badurinantun
Copy link
Contributor

@badurinantun badurinantun commented May 18, 2022 •
edited
Loading

Usage related changes

  • None

Development related changes

  • Replace TransactionWrapper class with DeventTransaction
  • Use respones object classes from Straknet
  • Add unit test for contract deployment

Checklist:

  • Performed a self-review of the code
  • Rebased to the base branch
  • Documented the changes
  • Updated the tests

@badurinantun badurinantun self-assigned this May 18, 2022
@badurinantun badurinantun marked this pull request as ready for review May 18, 2022 10:31
@badurinantun badurinantun requested a review from FabijanC May 18, 2022 10:31
FabijanC
FabijanC suggested changes May 18, 2022
View reviewed changes
Copy link
Collaborator

@FabijanC FabijanC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the conclusion of time performance impact of the made changes?

starknet_devnet/blocks.py Outdated Show resolved Hide resolved
starknet_devnet/origin.py Show resolved Hide resolved
starknet_devnet/transactions.py Show resolved Hide resolved
starknet_devnet/transactions.py Outdated Show resolved Hide resolved
test/test_deploy.py Show resolved Hide resolved
@FabijanC FabijanC self-requested a review May 18, 2022 12:35
@FabijanC FabijanC merged commit da74574 into master May 18, 2022
@FabijanC FabijanC deleted the use-types branch May 18, 2022 12:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@FabijanC FabijanC Awaiting requested review from FabijanC

Assignees

@badurinantun badurinantun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@badurinantun @FabijanC