This repository has been archived by the owner on Dec 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 77
Improvement : add endpoint to return fork status #347
Labels
Context: coupled
interact with some parts of the codebase
Difficulty: intermediate
mobilise some notions about the field, but can be learn
good first issue
Good for newcomers
Techno: python
Python
Type: feature
New feature or request
Comments
Hi, can I work on this issue? |
@ptisserand Yes you can! Although I believe first we would need to decide on the API. Here's my suggestion, let me know what you think:
You would need to create at least two tests (asserting response when forking and not) @ivpavici Do we have to do anything onlydust-wise? |
@FabijanC I agree with your suggestion |
Yeah, looks good! |
@FabijanC we did not add any new tasks on OnlyDust, but we could I guess |
For endpoint documentation, should I add it in |
@ptisserand yes. You can also create a PR (or a PR draft) so we can discuss there |
ptisserand
added a commit
to ptisserand/starknet-devnet
that referenced
this issue
Nov 25, 2022
ptisserand
added a commit
to ptisserand/starknet-devnet
that referenced
this issue
Nov 28, 2022
Repository owner
moved this from 📋 Backlog
to ✅ Done
in starknet-devnet
Nov 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Context: coupled
interact with some parts of the codebase
Difficulty: intermediate
mobilise some notions about the field, but can be learn
good first issue
Good for newcomers
Techno: python
Python
Type: feature
New feature or request
It could be useful to be able to request to devnet the fork info.
For example, with a such command :
curl -X GET http://127.0.0.1:5050/fork-status -H "Content-Type:application/json"
and have in return some infos :
The text was updated successfully, but these errors were encountered: