Remove PLP backwards-compatibility #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moodlezoup
requested review from
abandeali1,
dorothy-zbornak and
hysz
as code owners
dorothy-zbornak
approved these changes
Dec 15, 2020
dorothy-zbornak
added a commit
that referenced
this pull request
Dec 16, 2020
* `@0x/contracts-zero-ex`: Address audit feedback (1/2) * `@0x/contracts-zero-ex`: Cap the ETH transfer amount to a liquidity provider to `msg.value` * `@0x/contracts-zero-ex`: Bump feature contract versions * `@0x/contracts-zero-ex`: Always transfer msg.value to the liqudity provider in LiquiidityProviderFeature * Remove PLP backwards-compatibility (#85) * Remove backwards-compatibility from MixinZeroExBridge and LiquidityProviderSandbox * `@0x/contracts-zero-ex`: Update CHANGELOG Co-authored-by: Lawrence Forman <[email protected]> Co-authored-by: Lawrence Forman <[email protected]> Co-authored-by: mzhu25 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
All PLPs are now using the new interface. Removes backwards compatibility from
MixinZeroExBridgeandLiquidityProviderSandbox. This also fixes the issue ofLiquidityProviderSandboxswallowing errors.Testing instructions
Types of changes
Checklist:
[WIP]if necessary.