Fix: FQT otc order encoding logic [TKR-611] #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abls
requested changes
Oct 7, 2022
There was a problem hiding this comment.
I don't believe this will fix it. You have to remove the otcOrders field completely, it isn't present on-chain at all.
IMO would be best to just revert this commit.
|
Another approach is keeping two versions of FQT encoders (legacy, and otc-supporting version). |
dextracker
force-pushed
the
fix/FqtOtcEncoding
branch
from
33edad0 to
ee4a92b
Compare
added 2 commits
October 12, 2022 16:51
kyu-c
reviewed
Oct 12, 2022
| @@ -87,6 +82,11 @@ export const fillQuoteTransformerDataEncoder = AbiEncoder.create([ | |||
| { name: 'fillSequence', type: 'uint8[]' }, | |||
| { name: 'fillAmount', type: 'uint256' }, | |||
| { name: 'refundReceiver', type: 'address' }, | |||
| { | |||
There was a problem hiding this comment.
shouldn't there be an accompanying change in FQT (solidity code)?
There was a problem hiding this comment.
yup forgot to add from /protocol was in protocol-utils
dextracker
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
swap rfq and otc in fillQuoteTransformerDataEncoder to match our enum
Testing instructions
Types of changes
Checklist:
[WIP]if necessary.