Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: BalancerV2 sor alias #481

Merged
merged 3 commits into from
May 19, 2022
Merged

fix: BalancerV2 sor alias #481

merged 3 commits into from
May 19, 2022

Conversation

dekz
Copy link
Member

@dekz dekz commented May 19, 2022

Description

Inverted the package alias so load the latest version as @balancer-labs/sdk and @balancer-labs/sor.

So the previous version we relied @balancer-labs/[email protected] on is now referenced by balancer-labs-sor-v1.

Oddness with @balancer-labs/[email protected]

For some odd reason, in 0xAPI, when loading @balancer-labs/[email protected] no @balancer-labs/sor package was brought as a dependency.

λ cat node_modules/@balancer-labs/sdk/package.json| jq '.version'
"0.1.11"
λ ls node_modules/@balancer-labs
sdk

Asset-swapper has this version as ^0.1.6 which is what my local machine was using, which was populated with sor so it was difficult to reproduce.

When restricting this version explicitly to 0.1.6 my 0xAPI was then downloading the sor dependency as expected.

0x-api λ cat node_modules/@balancer-labs/sdk/package.json| jq '.version'
"0.1.6"
0x-api λ ls node_modules/@balancer-labs
sdk sor

For now I have pinned us to 0.1.6, maybe someone smarter than I can understand that exact cause.

Simbot (Ethereum includedSources=Balancer_V2)
Simbot (Avalanche)

Testing instructions

Types of changes

Checklist:

  • Prefix PR title with [WIP] if necessary.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • Add new entries to the relevant CHANGELOG.jsons.

@dekz dekz requested review from kyu-c and dextracker May 19, 2022 02:42
@dekz dekz changed the title Fix/balancer v2 sor fix: BalancerV2 sor alias May 19, 2022
@dekz dekz marked this pull request as ready for review May 19, 2022 02:46
Copy link
Contributor

@dextracker dextracker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dekz dekz merged commit 68f87b2 into development May 19, 2022
@dekz dekz deleted the fix/balancerV2-sor branch May 19, 2022 03:19
dextracker pushed a commit that referenced this pull request Jun 15, 2022
* Install both Balancer sor and rename early version to v1

* yarn.lock

* CHANGELOG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants