feat: add IRfqClient #467
Merged
feat: add IRfqClient #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhinodavid
reviewed
May 3, 2022
| feeToken: undefined, | ||
| }) | ||
| ).quotes as V4RFQIndicativeQuoteMM[]) | ||
| : await rfqt.quoteRequestor.requestRfqtIndicativeQuotesAsync( |
There was a problem hiding this comment.
is there a way we could make quoterequestor conform to IRfqClient so we don't have this weird branching? Or is it not worth it?
There was a problem hiding this comment.
I think it's better to have the IRfqClient conform to the existing code, otherwise, we need to change some stuff downstream. Riskier, for unclear benefit
rhinodavid
reviewed
May 3, 2022
| @@ -0,0 +1,23 @@ | |||
| import { FillQuoteTransformerOrderType } from '@0x/protocol-utils'; | |||
There was a problem hiding this comment.
consider just putting this in the interface file -- will be easier to clean up later
rhinodavid
approved these changes
May 3, 2022
rhinodavid
reviewed
May 4, 2022
| export interface RfqClientPriceRequest { | ||
| integratorId: string; |
kyu-c
reviewed
May 11, 2022
| export interface RfqClientV1PriceRequest { | ||
| altRfqAssetOfferings: AltRfqMakerAssetOfferings | undefined; | ||
| assetFillAmount: BigNumber; | ||
| chainId: number; |
There was a problem hiding this comment.
would be beneficial to use enum ChainId here instead?
| @@ -663,17 +666,49 @@ export class MarketOperationUtils { | |||
| // Timing of RFQT lifecycle | |||
| const timeStart = new Date().getTime(); | |||
| const { makerToken, takerToken } = nativeOrders[0].order; | |||
There was a problem hiding this comment.
[out of scope] it seems like fooToken sometimes mean the symbol(?) (e.g. RfqClientV1PriceRequest has both
takerAddress, and takerToken) while here it's address.
phil-ociraptor
added a commit
that referenced
this pull request
May 12, 2022
phil-ociraptor
added a commit
that referenced
this pull request
May 12, 2022
dextracker
pushed a commit
that referenced
this pull request
May 13, 2022
dextracker
pushed a commit
that referenced
this pull request
May 13, 2022
idokleinman
added a commit
that referenced
this pull request
May 17, 2022
* Add BiSwap (as UniV2 clone) on BSC * changelog PR number * add BSW * remove BiSwap from transformer_utils * Do not initialize BalancerV2SwapInfoCache on unsupported chains [TKR-365] (#472) * Do not initialize BalancerV2SwapInfoCache on unsupported chains * Update CHANGELOG.json * Updated CHANGELOGS & MD docs * Publish - @0x/[email protected] * chore: Decomission SnowSwap [TKR-356] (#468) * Decomission SnowSwap * SnowSwap doesn't have much liquidity anymore (the largest pool has ~$50k) * Update CHANGELOG.json * Update CHANGELOG.json * chore: Offboard Swerve Finance and LinkSwap [TKR-356] (#469) * Offboard swerve * Update CHANGELOG.json * Offboard LinkSwap * Remove unused import * Fix CHANGELOG.json * chore: Offboard Eth2Dai [TKR-356] (#470) * Offboard Eth2Dai * Update CHANGELOG.json * feat: add IRfqClient (#467) * add message to changelog for #467 (#474) * Update saddle mainnet pools (#450) * Add saddle v2 pools * remove outdated pools * add two saddle meta pools * forgot changelog * remove saddle metapools * changelog update * Fix a lint issue (#475) * Updated CHANGELOGS & MD docs * Publish - @0x/[email protected] * Add BiSwap (as UniV2 clone) on BSC * rebase new changes for balv2, up changelog, quotes working * remove Biswap from transformer_utils once again Co-authored-by: Kyu <[email protected]> Co-authored-by: Github Actions <[email protected]> Co-authored-by: phil-ociraptor <[email protected]> Co-authored-by: Cece Z <[email protected]> Co-authored-by: Noah Khamliche <[email protected]>
dextracker
pushed a commit
that referenced
this pull request
Jun 15, 2022
dextracker
pushed a commit
that referenced
this pull request
Jun 15, 2022
dextracker
added a commit
that referenced
this pull request
Jun 15, 2022
* Add BiSwap (as UniV2 clone) on BSC * changelog PR number * add BSW * remove BiSwap from transformer_utils * Do not initialize BalancerV2SwapInfoCache on unsupported chains [TKR-365] (#472) * Do not initialize BalancerV2SwapInfoCache on unsupported chains * Update CHANGELOG.json * Updated CHANGELOGS & MD docs * Publish - @0x/[email protected] * chore: Decomission SnowSwap [TKR-356] (#468) * Decomission SnowSwap * SnowSwap doesn't have much liquidity anymore (the largest pool has ~$50k) * Update CHANGELOG.json * Update CHANGELOG.json * chore: Offboard Swerve Finance and LinkSwap [TKR-356] (#469) * Offboard swerve * Update CHANGELOG.json * Offboard LinkSwap * Remove unused import * Fix CHANGELOG.json * chore: Offboard Eth2Dai [TKR-356] (#470) * Offboard Eth2Dai * Update CHANGELOG.json * feat: add IRfqClient (#467) * add message to changelog for #467 (#474) * Update saddle mainnet pools (#450) * Add saddle v2 pools * remove outdated pools * add two saddle meta pools * forgot changelog * remove saddle metapools * changelog update * Fix a lint issue (#475) * Updated CHANGELOGS & MD docs * Publish - @0x/[email protected] * Add BiSwap (as UniV2 clone) on BSC * rebase new changes for balv2, up changelog, quotes working * remove Biswap from transformer_utils once again Co-authored-by: Kyu <[email protected]> Co-authored-by: Github Actions <[email protected]> Co-authored-by: phil-ociraptor <[email protected]> Co-authored-by: Cece Z <[email protected]> Co-authored-by: Noah Khamliche <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow
SwapQuoterto use anIRfqClientto fetch quotes instead of usingQuoteRequestor. This allows different implementations for quote fetching.Testing instructions
Types of changes
Checklist:
[WIP]if necessary.