Filter unprovable killer txn tests #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nashtare
force-pushed
the
blacklist-unprovable
branch
from
9e99f48 to
0d3bb4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests used for stress testing incur too much overhead on the zkEVM to be actually provable (i.e. they go over Goldilocks' prime subgroup size of 2^32 elements). As such, they cannot be proven with the current system we use. While continuations would solve this, proving 50Billion CPU cycles would just be too much anyway.
We can still generate their witnesses, in
-wmode, but each take few hundred GBs, and require several hours of execution. These tests on their own don't bring much, so they can be safely removed. Smaller variants are still included when parsing and processing the tests.