Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temp hack for filling in the expected state trie hash #15

Merged
merged 3 commits into from
Feb 27, 2023
Merged

Conversation

BGluth
Copy link
Collaborator

@BGluth BGluth commented Feb 27, 2023

Just to get things going, sets the expected state trie hash to the hash in the first entry in merge. This is fine for tests with one txn variant, but incorrect for ones with multiple. Will fix soon.

- Just to get things going, sets the expected state trie hash to the
  hash in the first entry in merge. This is fine for tests with one txn
  variant, but incorrect for ones with multiple. Will fix soon.
@BGluth BGluth requested a review from dlubarov February 27, 2023 17:27
@BGluth
Copy link
Collaborator Author

BGluth commented Feb 27, 2023

I would ignore the clippy failure. It's a bug in clap, and we can't temporarily override this with a #[allow(clippy::*)] due to clap placing a deny inside the macro expansion.

Copy link
Contributor

@dlubarov dlubarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BGluth BGluth merged commit 02a23d1 into main Feb 27, 2023
@BGluth BGluth deleted the state_hash_hack branch February 27, 2023 21:15
dlubarov pushed a commit that referenced this pull request Mar 7, 2023
Temp hack for filling in the expected state trie hash
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants