Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move errors to build in TransactionRequestBuilder #750

Merged
merged 3 commits into from
Feb 24, 2025

Conversation

tomyrd
Copy link
Collaborator

@tomyrd tomyrd commented Feb 20, 2025

closes #622

Most of the changes are just moving around the unwraps in the tests. I think the important part is the changes in crates/rust-client/src/transaction/request/builder.rs

@tomyrd tomyrd force-pushed the tomyrd-transaction-builder-error branch from 4562d8f to 55ed0de Compare February 20, 2025 18:41
Copy link
Collaborator

@SantiagoPittella SantiagoPittella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@igamigo igamigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think the preset transaction requests (pay_to_id, swap, mint_fungible_asset, etc) should likely return TransactionRequest now. But we could do this on a different PR

@igamigo igamigo merged commit 2183ab9 into next Feb 24, 2025
13 checks passed
@igamigo igamigo deleted the tomyrd-transaction-builder-error branch February 24, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants