feat: Separate TransactionRequest and TransactionRequestBuilder
#605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into igamigo-tx-request-builder
tomyrd
approved these changes
Nov 25, 2024
SantiagoPittella
approved these changes
Nov 29, 2024
| @@ -1,65 +1,38 @@ | |||
| //! Contains structures and functions related to transaction creation. | |||
There was a problem hiding this comment.
Should we keep this top level documentation? This is the docs that the rust docs pages will use to describe the whole mod.
There was a problem hiding this comment.
Yeah, I believe when I moved things around I removed it accidentally. also moved the struct header below the imports.
bobbinth
approved these changes
Dec 1, 2024
There was a problem hiding this comment.
Looks good! Thank you!
A potentially different alternative to error handling could have been to fail only on TransactionRequestBuilder::build() method instead of on the individual property setters. But it has its own pros and cons, and if we decide to do it that way, it can be done in a different PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #580