Skip to content

Commit

Permalink
refactor: move sandbox configuration to script
Browse files Browse the repository at this point in the history
  • Loading branch information
tomyrd committed Feb 24, 2025
1 parent 7294c2b commit 5e9d4a2
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 10 deletions.
12 changes: 2 additions & 10 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -60,11 +60,7 @@ jobs:
with:
node-version: "20"
- name: Configure setuid sandbox
run: |
CHROME_DEVEL_SANDBOX=/opt/google/chrome/chrome-sandbox
echo "CHROME_DEVEL_SANDBOX=$CHROME_DEVEL_SANDBOX" >> $GITHUB_ENV
sudo chown root:root $CHROME_DEVEL_SANDBOX
sudo chmod 4755 $CHROME_DEVEL_SANDBOX
run: ./scripts/configure-sandbox.sh
- run: make clean-node
- run: make node
- run: make start-node > /dev/null &
Expand All @@ -87,11 +83,7 @@ jobs:
with:
node-version: "20"
- name: Configure setuid sandbox
run: |
CHROME_DEVEL_SANDBOX=/opt/google/chrome/chrome-sandbox
echo "CHROME_DEVEL_SANDBOX=$CHROME_DEVEL_SANDBOX" >> $GITHUB_ENV
sudo chown root:root $CHROME_DEVEL_SANDBOX
sudo chmod 4755 $CHROME_DEVEL_SANDBOX
run: ./scripts/configure-sandbox.sh
- run: make clean-node
- run: make node
- run: make start-node > /dev/null &
Expand Down
4 changes: 4 additions & 0 deletions scripts/configure-sandbox.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
CHROME_DEVEL_SANDBOX=/opt/google/chrome/chrome-sandbox
echo "CHROME_DEVEL_SANDBOX=$CHROME_DEVEL_SANDBOX" >> $GITHUB_ENV
sudo chown root:root $CHROME_DEVEL_SANDBOX
sudo chmod 4755 $CHROME_DEVEL_SANDBOX

0 comments on commit 5e9d4a2

Please sign in to comment.