feat: re-export RemoteTransactionProver (#752)

* feat: re-export `RemoteTransactionProver`
0xPolygonMiden · Feb 24, 2025 · 091be89 · 091be89
1 parent 2183ab9
commit 091be89
Show file tree

Hide file tree

Showing 9 changed files with 11 additions and 13 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -10,7 +10,8 @@
 
 * Add check for empty pay to id notes (#714).
 * [BREAKING] Refactored authentication out of the `Client` and added new separate authenticators (#718).
-* Move error handling to the `TransactionRequestBuilder::build()` (#750).
+* Re-exported RemoteTransactionProver in `rust-client` (#752).
+* Moved error handling to the `TransactionRequestBuilder::build()` (#750).
 
 ## 0.7.0 (2025-01-28)
 

diff --git a/Cargo.lock b/Cargo.lock
diff --git a/bin/miden-cli/Cargo.toml b/bin/miden-cli/Cargo.toml
@@ -40,7 +40,6 @@ comfy-table = { version = "7.1" }
 figment = { version = "0.10", features = ["toml", "env"] }
 miden-client = { version = "0.8", path = "../../crates/rust-client", features = ["sqlite", "tonic"] }
 miden-lib = { workspace = true }
-miden-proving-service-client = { workspace = true , features = ["std", "tx-prover"]}
 miden-objects = { workspace = true }
 miette = { workspace = true }
 rand = { workspace = true }

diff --git a/bin/miden-cli/src/commands/new_transactions.rs b/bin/miden-cli/src/commands/new_transactions.rs
@@ -11,9 +11,8 @@ use miden_client::{
         InputNote, OutputNote, PaymentTransactionData, SwapTransactionData, TransactionRequest,
         TransactionRequestBuilder, TransactionResult,
     },
-    Client,
+    Client, RemoteTransactionProver,
 };
-use miden_proving_service_client::proving_service::tx_prover::RemoteTransactionProver;
 use tracing::info;
 
 use crate::{

diff --git a/crates/rust-client/Cargo.toml b/crates/rust-client/Cargo.toml
@@ -23,7 +23,7 @@ concurrent = ["miden-tx/concurrent", "std"]
 default = []
 idxdb = ["dep:base64", "dep:serde-wasm-bindgen", "dep:wasm-bindgen", "dep:wasm-bindgen-futures", "dep:serde"]
 sqlite = ["dep:rusqlite", "dep:deadpool-sqlite", "std"]
-std = ["miden-objects/std"]
+std = ["miden-objects/std","miden-proving-service-client/std"]
 testing = ["miden-objects/testing", "miden-lib/testing", "miden-tx/testing"]
 tonic = ["std", "tonic/transport", "tonic/tls", "tonic/tls-native-roots"]
 web-tonic = ["dep:tonic-web-wasm-client"]
@@ -34,6 +34,7 @@ base64 = { version = "0.22", optional = true }
 chrono = { version = "0.4", optional = false }
 deadpool-sqlite = { version = "0.9", features = ["rt_tokio_1"], optional = true }
 hex = { version = "0.4" }
+miden-proving-service-client = { workspace = true , features = ["tx-prover"]}
 miden-lib = { workspace = true }
 miden-objects = { workspace = true }
 miden-tx = { workspace = true, features = ["async"] }

diff --git a/crates/rust-client/src/lib.rs b/crates/rust-client/src/lib.rs
@@ -168,6 +168,7 @@ pub mod crypto {
 
 pub use errors::{ClientError, IdPrefixFetchError};
 pub use miden_objects::{Felt, StarkField, Word, ONE, ZERO};
+pub use miden_proving_service_client::proving_service::tx_prover::RemoteTransactionProver;
 
 /// Provides various utilities that are commonly used throughout the Miden
 /// client library.

diff --git a/crates/web-client/Cargo.toml b/crates/web-client/Cargo.toml
@@ -25,7 +25,6 @@ testing = ["miden-client/testing"]
 miden-client = { version = "0.8", path = "../rust-client", default-features = false, features = ["idxdb", "web-tonic"] }
 miden-lib = { workspace = true }
 miden-objects = { workspace = true }
-miden-proving-service-client = { workspace = true }
 miden-tx = { workspace = true }
 rand = { workspace = true }
 serde = { workspace = true }

diff --git a/crates/web-client/src/lib.rs b/crates/web-client/src/lib.rs
@@ -6,10 +6,9 @@ use miden_client::{
     authenticator::{keystore::WebKeyStore, ClientAuthenticator},
     rpc::WebTonicRpcClient,
     store::web_store::WebStore,
-    Client,
+    Client, RemoteTransactionProver,
 };
 use miden_objects::{crypto::rand::RpoRandomCoin, Felt};
-use miden_proving_service_client::proving_service::tx_prover::RemoteTransactionProver;
 use rand::{rngs::StdRng, Rng, SeedableRng};
 use wasm_bindgen::prelude::*;
 

diff --git a/crates/web-client/src/models/provers.rs b/crates/web-client/src/models/provers.rs
@@ -1,9 +1,9 @@
 use alloc::sync::Arc;
 
-use miden_client::transaction::{
-    LocalTransactionProver, TransactionProver as TransactionProverTrait,
+use miden_client::{
+    transaction::{LocalTransactionProver, TransactionProver as TransactionProverTrait},
+    RemoteTransactionProver,
 };
-use miden_proving_service_client::proving_service::tx_prover::RemoteTransactionProver;
 use miden_tx::ProvingOptions;
 use wasm_bindgen::prelude::*;