Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing issues in key-value database #548

Merged
merged 16 commits into from
Sep 14, 2023
Merged

Fixing issues in key-value database #548

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
b4dd44e
Version test remote
rickb80 Sep 8, 2023
6ee53dc
Merge remote-tracking branch 'origin/develop' into rick/testing_KVDat…
rickb80 Sep 8, 2023
eff0663
Avoid hashKey duplicity in associative caches...
rickb80 Sep 8, 2023
9de3981
Add getTree as last option for KV and fixes
rickb80 Sep 8, 2023
437022a
Don not fill kv_associative_cache with repeated values
rickb80 Sep 8, 2023
591d221
Add zeros into KVCache
rickb80 Sep 8, 2023
7bda7db
Fixed multiwrite usage for keyValue
rickb80 Sep 8, 2023
b91ecca
Manage links among versions in kv cache, eliminate update
rickb80 Sep 12, 2023
498733c
readRemoteKV extracts the upstream versions
rickb80 Sep 12, 2023
b5f423f
Merge remote-tracking branch 'origin/develop' into rick/testing_KVDat…
rickb80 Sep 13, 2023
7e13644
downstreamAddKeyZero and uploadKeyValueVersion
rickb80 Sep 13, 2023
c35607e
fix issues in the kv cache design
rickb80 Sep 13, 2023
849e8d4
Merge remote-tracking branch 'origin/develop' into rick/testing_KVDat…
rickb80 Sep 13, 2023
faebe03
Fixes in KV cacha and database
rickb80 Sep 13, 2023
f0bc8d9
Merge remote-tracking branch 'origin/develop' into rick/testing_KVDat…
rickb80 Sep 14, 2023
d299ccc
Fix missing argument in ReadTree
rickb80 Sep 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add zeros into KVCache
  • Loading branch information
@rickb80
rickb80 committed Sep 8, 2023
commit 591d22119637742f6a609eceed07b6398124fbdd
10 changes: 9 additions & 1 deletion src/hashdb64/database_64.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,6 +423,8 @@ zkresult Database64::readKV(const Goldilocks::Element (&root)[4], const Goldiloc
if( rkv == ZKR_DB_VERSION_NOT_FOUND_GLOBAL){
value = 0;
rout = rkv;
mpz_class zero(0);
dbKVACache.addKeyValueVersion(version, key, zero, false);
}else{
zkresult rtree = ZKR_UNSPECIFIED;
vector<KeyValue> keyValues(1);
Expand Down Expand Up @@ -1406,7 +1408,13 @@ zkresult Database64::writeRemoteKV(const uint64_t version, const Goldilocks::Ele
}
insertStr = insertStr + data;
}
}
} else{
if(version > 1){
//this must be reproduced into multiwrite
mpz_class zero(0);
dbKVACache.addKeyValueVersion(version-1, key, zero, false);
}
}
}
catch (const std::exception &e)
{
Expand Down