Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Keccak executor tests #533

Merged
merged 4 commits into from
Sep 6, 2023
Merged

Fix Keccak executor tests #533

merged 4 commits into from
Sep 6, 2023

Conversation

nadimkobeissi
Copy link
Contributor

@nadimkobeissi nadimkobeissi commented Sep 4, 2023

Fix Keccak state machine executor tests + continue major cleanup of Keccak gate-based implementation and state machine code.

  • Fix Keccak state machine executor test! Finally.
  • Remove almost all #defines for Keccak and standardize the use of GateConfig interface via KeccakGateConfig instead.
  • Remove all dead or non-functional overloaded interfaces for the Keccak executor.
  • Actually initialize the executor program when running tests and add a zkassertpermanent to prevent the executor from running without a loaded program/configuration. This is what delayed fixing the tests so much: we were running the executor on blanks without noticing because it dropped loading the program in some cases.

@cla-bot cla-bot bot added the cla-signed label Sep 4, 2023
@nadimkobeissi nadimkobeissi marked this pull request as ready for review September 6, 2023 10:33
@nadimkobeissi nadimkobeissi changed the title Fixing Keccak executor tests (WIP) Fixing Keccak executor tests Sep 6, 2023
@nadimkobeissi nadimkobeissi changed the title Fixing Keccak executor tests Fix Keccak executor tests Sep 6, 2023
@nadimkobeissi nadimkobeissi merged commit 92f09c0 into develop Sep 6, 2023
@nadimkobeissi nadimkobeissi deleted the nadim-executor branch September 7, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant