Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Keccak state machine executor tests + continue major cleanup of Keccak gate-based implementation and state machine code.
#define
s for Keccak and standardize the use ofGateConfig
interface viaKeccakGateConfig
instead.zkassertpermanent
to prevent the executor from running without a loaded program/configuration. This is what delayed fixing the tests so much: we were running the executor on blanks without noticing because it dropped loading the program in some cases.