add column checked on state.block #3543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joanestebanr
requested review from
ARR552,
ToniRamirezM and
tclemos
as code owners
ARR552
approved these changes
Apr 8, 2024
Stefan-Ethernal
pushed a commit
to 0xPolygon/cdk-validium-node
that referenced
this pull request
Apr 10, 2024
* add column checked on state.block * if no unchecked blocks return ErrNotFound * migration set to checked all but the block with number below max-1000
Stefan-Ethernal
added a commit
to 0xPolygon/cdk-validium-node
that referenced
this pull request
Apr 10, 2024
* fix tx index calculation on receipt (0xPolygonHermez#3488) * fix debug trace to compute egp percentage based on tx execution values (0xPolygonHermez#3503) * fix debug trace to compute egp percentage based on tx execution values * fix trace egp percentage for injected tx * sort logs by tx hash and then by log index (0xPolygonHermez#3476) * * Fix ResetL1InfoRoot + typos * mocks * linter * refactor * more robust * Fix comments * Add extra check reorg after calling get information * Fix non e2e test * Feature/3518 use generic eth client for l2 (0xPolygonHermez#3519) * 0xPolygonHermez#3518 compatibility with ethereum-API L2 node * migrate docker-compose to v2 because ubuntu:latest have deprecated it * fix case trusted URL is not set * fix deltaTimeStamp and TimestampLimit for eth_call (0xPolygonHermez#3529) * Stop syncing l1inforoot when invalid l1inforoot is detected (0xPolygonHermez#3542) * stop syncing l1inforoot when invalid l1inforoot is detected * fix linter * Feature/0xPolygonHermez#3544 sync block protection (0xPolygonHermez#3545) * SyncBlockProtection parameter * linter * config * Fix unit test * add column checked on state.block (0xPolygonHermez#3543) * add column checked on state.block * if no unchecked blocks return ErrNotFound * migration set to checked all but the block with number below max-1000 * safe mode by default (0xPolygonHermez#3547) * safe mode by default * doc * update docs * Update the diff --------- Co-authored-by: Toni Ramírez <[email protected]> Co-authored-by: Thiago Coimbra Lemos <[email protected]> Co-authored-by: Alonso Rodriguez <[email protected]> Co-authored-by: Joan Esteban <[email protected]> Co-authored-by: agnusmor <[email protected]> Co-authored-by: Rachit Sonthalia <[email protected]>
ARR552
added a commit
that referenced
this pull request
Apr 23, 2024
* add column checked on state.block * if no unchecked blocks return ErrNotFound * migration set to checked all but the block with number below max-1000
ARR552
added a commit
that referenced
this pull request
Apr 25, 2024
* change number migration * add column checked on state.block * if no unchecked blocks return ErrNotFound * migration set to checked all but the block with number below max-1000 * add column checked on state.block (#3543) * add column checked on state.block * if no unchecked blocks return ErrNotFound * migration set to checked all but the block with number below max-1000 * Feature/#3549 reorgs improvement (#3553) * New reorg function * mocks * linter * Synchronizer tests * new elderberry smc docker image * new image * logs * fix json rpc * fix * Test sync from empty block * Regular reorg case tested * linter * remove empty block + fix LatestSyncedBlockEmpty * Improve check reorgs when no block is received during the call * fix RPC error code for eth_estimateGas and eth_call for reverted tx and no return value; fix e2e test; * fix test * Extra unit test * fix reorg until genesis * disable parallel synchronization --------- Co-authored-by: tclemos <[email protected]> * migrations * Fix + remove empty blocks * unit test * linter * Fix + remove empty blocks (#3564) * Fix + remove empty blocks * unit test * linter * Fix/#3565 reorg (#3566) * fix + logs * fix loop * Revert "fix + logs" This reverts commit 39ced69. * fix L1InfoRoot when an error happens during the process of the L1 information (#3576) * fix * Comments + mock * avoid error from some L1providers when fromBlock is higher than toBlock * Revert some changes * comments * add L2BlockModulus to L1check * doc * fix dbTx = nil * fix unit tests * config * fix sync unit test * linter * fix config param typo * synchronizer: check l1blocks (#3546) * wip * run on background L1block checker * fix lint and documentation * fix conflict * add unittest * more unittest * fix lint * increase timeout for async unittest * fix unittest * rename GetResponse for GetResult and fix uniitest * add a second gorutines for check the newest blocks * more unittest * add unittest and run also preCheck on launch * by default Precheck from FINALIZED and SAFE * fix unittest, apply PR comments * changes suggested by ARR552 in integration method * fix documentation * import new network-l1-mock from PR#3553 * import new network-l1-mock from PR#3553 * import new network-l1-mock from PR#3553 * import new network-l1-mock from PR#3553 * fix unittest * fix PR comments * fix error * checkReorgAndExecuteReset can't be call with lastEthBlockSynced=nil * add parentHash to error * fix error * merge 3553 fix unittest * fix unittest * fix wrong merge * adapt parallel reorg detection to flow * fix unit tests * fix log * allow use sync parallel mode --------- Co-authored-by: Alonso <[email protected]> * linter * comment check --------- Co-authored-by: tclemos <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3541
What does this PR do?
add column checked to state.block
Reviewers
Main reviewers:
Codeowner reviewers: