-
Notifications
You must be signed in to change notification settings - Fork 724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IP and ZKCounter Validation, Refactor Batch Configs #2298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Psykepro
added
sequencer
rpc
improvement
pool
config
bug
Something isn't working
labels
Jul 18, 2023
Psykepro
force-pushed
the
bugfix/ip-validation
branch
2 times, most recently
from
July 18, 2023 14:40
e60b3f4
to
8af4eb9
Compare
Psykepro
force-pushed
the
bugfix/ip-validation
branch
2 times, most recently
from
July 19, 2023 09:59
7ede197
to
6edbb17
Compare
Psykepro
changed the title
Enhance Security: Add IP and ZKCounter Validation, Refactor Batch Configs
Add IP and ZKCounter Validation, Refactor Batch Configs
Jul 19, 2023
tclemos
requested changes
Jul 25, 2023
Signed-off-by: Nikolay Nedkov <[email protected]>
Signed-off-by: Nikolay Nedkov <[email protected]>
Psykepro
force-pushed
the
bugfix/ip-validation
branch
from
July 27, 2023 12:16
93072e2
to
df00068
Compare
Signed-off-by: Nikolay Nedkov <[email protected]>
Psykepro
force-pushed
the
bugfix/ip-validation
branch
from
July 27, 2023 13:06
26f5184
to
c002aab
Compare
tclemos
approved these changes
Jul 27, 2023
Psykepro
force-pushed
the
bugfix/ip-validation
branch
2 times, most recently
from
July 27, 2023 13:30
cf3b3e7
to
0372625
Compare
Signed-off-by: Nikolay Nedkov <[email protected]>
Psykepro
force-pushed
the
bugfix/ip-validation
branch
from
July 27, 2023 13:35
0372625
to
7d1b672
Compare
Signed-off-by: Nikolay Nedkov <[email protected]>
Signed-off-by: Nikolay Nedkov <[email protected]>
Psykepro
force-pushed
the
bugfix/ip-validation
branch
from
August 15, 2023 10:09
d442865
to
9d928c2
Compare
ToniRamirezM
approved these changes
Aug 16, 2023
…ix env vars resolving for 'permisionless-node'. Signed-off-by: Nikolay Nedkov <[email protected]>
Signed-off-by: Nikolay Nedkov <[email protected]>
Psykepro
force-pushed
the
bugfix/ip-validation
branch
from
August 18, 2023 15:27
ea55e23
to
a6a1243
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2284.
What does this PR do?
This pull request introduces some crucial enhancements aimed at optimizing our system's resource management and ensuring a more consistent operation.
Changes
Transaction Pool IP Verification:
tryToAddTxToPool
function. This new feature checks the validity of IP addresses obtained from theX-Forwarded-For
header.Worker's IP Verification:
Worker.AddTxTracker
. This helps ensure that all transactions are associated with valid IP addresses before being added to the efficiency list.BatchConfig Integration and Verification:
The
BatchConstraints
andBatchResourceWeights
configuration values have been streamlined into a unifiedBatchConfig
structure. TheJSON-RPC
now utilizes this to check if a transaction stays within the predefined resource constraints. Transactions surpassing these constraints will be prevented from entering the transaction pool. Similarly, theSequencer
will sidestep such transactions, ensuring they are not added to the Worker's efficiency list.The
State
,StateDB
andBatch
Config Parameters now will look like that:Reviewers
Codeowner reviewers: