Hotfix/v0.1.3 #2173
Merged
Hotfix/v0.1.3 #2173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ToniRamirezM
previously approved these changes
Jun 8, 2023
ARR552
reviewed
Jun 9, 2023
Comment on lines
+26
to
+59
| // function opDelegateCallSelfBalance( | ||
| // address addrCall | ||
| // ) external payable returns (uint256) { | ||
| // addrCall.call{value: msg.value}( | ||
| // abi.encodeWithSignature("opDelegateCallSelfBalance()") | ||
| // ); | ||
| // assembly { | ||
| // let val := address() | ||
| // sstore(0x3, val) | ||
| // let val2 := codesize() | ||
| // sstore(0x4, val2) | ||
| // let val3 := msize() | ||
| // codecopy(val3, 0x0, val2) | ||
| // let val4 := mload(val3) | ||
| // sstore(0x5, val3) | ||
| // } | ||
| // } | ||
|
|
||
| // function opDelegateDelegateSelfBalance( | ||
| // address addrCall | ||
| // ) external payable returns (uint256) { | ||
| // addrCall.delegatecall( | ||
| // abi.encodeWithSignature("opDelegateCallSelfBalance()") | ||
| // ); | ||
| // assembly { | ||
| // let val := address() | ||
| // sstore(0x3, val) | ||
| // let val2 := codesize() | ||
| // sstore(0x4, val2) | ||
| // let val3 := msize() | ||
| // codecopy(val3, 0x0, val2) | ||
| // let val4 := mload(val3) | ||
| // sstore(0x5, val3) | ||
| // } |
There was a problem hiding this comment.
Why do we need to keep this commented code?
ToniRamirezM
previously approved these changes
Jun 9, 2023
* make max grpc message size configurable * fix state tests * fix tests * fix tests
* optimize trace * fix memory reading * update docker image * update prover image * fix converter * fix memory * fix step memory * fix structlogs * fix structlogs * fix structlogs * fix structlogs * fix structlogs * fix structlogs * fix structlogs * fix structlogs * update prover image * fix struclogs * fix memory size * fix memory size * fix memory size * refactor memory resize * refactor memory resize
This reverts commit 860f0e7.
Fix GetWIPBatch when previous last batch is a forced batch
Hotfix/forced batch
* Fix BatchL2Data * Force GHA
ToniRamirezM
approved these changes
Jun 26, 2023
ToniRamirezM
added a commit
that referenced
this pull request
Jun 26, 2023
* fix concurrent web socket writes * fix eth_syncing * fix custom trace internal tx call error handling and update prover * add test to custom tracer depth issue; fix internal call error and gas used * fix custom tracer for internal tx with error and no more steps after it * remove debug code * Make max grpc message size configurable (#2179) * make max grpc message size configurable * fix state tests * fix tests * fix tests * get SequencerNodeURI from SC if empty and not IsTrustedSequencer * Optimize trace (#2183) * optimize trace * fix memory reading * update docker image * update prover image * fix converter * fix memory * fix step memory * fix structlogs * fix structlogs * fix structlogs * fix structlogs * fix structlogs * fix structlogs * fix structlogs * fix structlogs * update prover image * fix struclogs * fix memory size * fix memory size * fix memory size * refactor memory resize * refactor memory resize * move log for the best fitting tx (#2192) * fix load zkCounters from pool * remove unnecessary log.info * add custom tracer support to CREATES opcode without depth increase (#2213) * logs * fix getting stateroot from previous batch (GetWIPBatch) * logs * Fix GetWipBatch when previous last batch is a forced batch * fix forcedBatch trusted state * Revert "fix getting stateroot from previous batch (GetWIPBatch)" This reverts commit 860f0e7. * force GHA * add pool limits (#2189) * Hotfix/batch l2 data (#2223) * Fix BatchL2Data * Force GHA --------- Co-authored-by: Toni Ramírez <[email protected]> Co-authored-by: agnusmor <[email protected]> Co-authored-by: agnusmor <[email protected]> Co-authored-by: Alonso <[email protected]> Co-authored-by: Alonso Rodriguez <[email protected]>
ToniRamirezM
added a commit
that referenced
this pull request
Jun 26, 2023
* Hotfix/v0.1.3 (#2173) * fix concurrent web socket writes * fix eth_syncing * fix custom trace internal tx call error handling and update prover * add test to custom tracer depth issue; fix internal call error and gas used * fix custom tracer for internal tx with error and no more steps after it * remove debug code * Make max grpc message size configurable (#2179) * make max grpc message size configurable * fix state tests * fix tests * fix tests * get SequencerNodeURI from SC if empty and not IsTrustedSequencer * Optimize trace (#2183) * optimize trace * fix memory reading * update docker image * update prover image * fix converter * fix memory * fix step memory * fix structlogs * fix structlogs * fix structlogs * fix structlogs * fix structlogs * fix structlogs * fix structlogs * fix structlogs * update prover image * fix struclogs * fix memory size * fix memory size * fix memory size * refactor memory resize * refactor memory resize * move log for the best fitting tx (#2192) * fix load zkCounters from pool * remove unnecessary log.info * add custom tracer support to CREATES opcode without depth increase (#2213) * logs * fix getting stateroot from previous batch (GetWIPBatch) * logs * Fix GetWipBatch when previous last batch is a forced batch * fix forcedBatch trusted state * Revert "fix getting stateroot from previous batch (GetWIPBatch)" This reverts commit 860f0e7. * force GHA * add pool limits (#2189) * Hotfix/batch l2 data (#2223) * Fix BatchL2Data * Force GHA --------- Co-authored-by: Toni Ramírez <[email protected]> Co-authored-by: agnusmor <[email protected]> Co-authored-by: agnusmor <[email protected]> Co-authored-by: Alonso <[email protected]> Co-authored-by: Alonso Rodriguez <[email protected]> * fix test --------- Co-authored-by: Thiago Coimbra Lemos <[email protected]> Co-authored-by: agnusmor <[email protected]> Co-authored-by: agnusmor <[email protected]> Co-authored-by: Alonso <[email protected]> Co-authored-by: Alonso Rodriguez <[email protected]>
joanestebanr
pushed a commit
that referenced
this pull request
Jun 28, 2023
* Hotfix/v0.1.3 (#2173) * fix concurrent web socket writes * fix eth_syncing * fix custom trace internal tx call error handling and update prover * add test to custom tracer depth issue; fix internal call error and gas used * fix custom tracer for internal tx with error and no more steps after it * remove debug code * Make max grpc message size configurable (#2179) * make max grpc message size configurable * fix state tests * fix tests * fix tests * get SequencerNodeURI from SC if empty and not IsTrustedSequencer * Optimize trace (#2183) * optimize trace * fix memory reading * update docker image * update prover image * fix converter * fix memory * fix step memory * fix structlogs * fix structlogs * fix structlogs * fix structlogs * fix structlogs * fix structlogs * fix structlogs * fix structlogs * update prover image * fix struclogs * fix memory size * fix memory size * fix memory size * refactor memory resize * refactor memory resize * move log for the best fitting tx (#2192) * fix load zkCounters from pool * remove unnecessary log.info * add custom tracer support to CREATES opcode without depth increase (#2213) * logs * fix getting stateroot from previous batch (GetWIPBatch) * logs * Fix GetWipBatch when previous last batch is a forced batch * fix forcedBatch trusted state * Revert "fix getting stateroot from previous batch (GetWIPBatch)" This reverts commit 860f0e7. * force GHA * add pool limits (#2189) * Hotfix/batch l2 data (#2223) * Fix BatchL2Data * Force GHA --------- Co-authored-by: Toni Ramírez <[email protected]> Co-authored-by: agnusmor <[email protected]> Co-authored-by: agnusmor <[email protected]> Co-authored-by: Alonso <[email protected]> Co-authored-by: Alonso Rodriguez <[email protected]> * fix test --------- Co-authored-by: Thiago Coimbra Lemos <[email protected]> Co-authored-by: agnusmor <[email protected]> Co-authored-by: agnusmor <[email protected]> Co-authored-by: Alonso <[email protected]> Co-authored-by: Alonso Rodriguez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2124
Closes #2172
Closes #2168
Closes #2160
Closes #2212
What does this PR do?
New Config Parameter:
[Executor]
MaxGRPCMessageSize = 100000000
Reviewers
Main reviewers:
@ToniRamirezM
@agnusmor