fix and add tests for safe and finalized l2 blocks (#2424)

0xPolygonHermez · Aug 22, 2023 · ce39e1d · ce39e1d
1 parent 659b082
commit ce39e1d
Show file tree

Hide file tree

Showing 2 changed files with 117 additions and 2 deletions.
diff --git a/state/pgstatestorage.go b/state/pgstatestorage.go
@@ -1521,7 +1521,7 @@ func (p *PostgresStorage) GetSafeL2BlockNumber(ctx context.Context, l1SafeBlockN
       FROM state.l2block b
      INNER JOIN state.virtual_batch vb
         ON vb.batch_num = b.batch_num
-	 WHERE vb.block_num >= $1
+	 WHERE vb.block_num <= $1
      ORDER BY b.block_num DESC LIMIT 1`
 
 	q := p.getExecQuerier(dbTx)
@@ -1545,7 +1545,7 @@ func (p *PostgresStorage) GetFinalizedL2BlockNumber(ctx context.Context, l1Final
       FROM state.l2block b
 	 INNER JOIN state.verified_batch vb
 	    ON vb.batch_num = b.batch_num
-	 WHERE vb.block_num >= $1
+	 WHERE vb.block_num <= $1
      ORDER BY b.block_num DESC LIMIT 1`
 
 	q := p.getExecQuerier(dbTx)

diff --git a/state/pgstatestorage_test.go b/state/pgstatestorage_test.go
@@ -438,3 +438,118 @@ func TestVirtualBatch(t *testing.T) {
 	require.Equal(t, virtualBatch, *actualVirtualBatch)
 	require.NoError(t, dbTx.Commit(ctx))
 }
+
+func TestGetSafeL2BlockNumber(t *testing.T) {
+	initOrResetDB()
+	ctx := context.Background()
+	dbTx, err := testState.BeginStateTransaction(ctx)
+	require.NoError(t, err)
+	defer func() { require.NoError(t, dbTx.Commit(ctx)) }()
+
+	// prepare data
+	addr := common.HexToAddress("0xf39Fd6e51aad88F6F4ce6aB8827279cffFb92266")
+	hash := common.HexToHash("0x29e885edaf8e4b51e1d2e05f9da28161d2fb4f6b1d53827d9b80a23cf2d7d9f1")
+	for i := 1; i <= 10; i++ {
+		// add l1 block
+		err = testState.AddBlock(ctx, state.NewBlock(uint64(i)), dbTx)
+		require.NoError(t, err)
+
+		// add batch
+		_, err = testState.PostgresStorage.Exec(ctx, "INSERT INTO state.batch (batch_num) VALUES ($1)", i)
+		require.NoError(t, err)
+
+		// add l2 block
+		l2Block := types.NewBlockWithHeader(&types.Header{Number: big.NewInt(int64(i + 10))})
+		err = testState.AddL2Block(ctx, uint64(i), l2Block, []*types.Receipt{}, uint8(0), dbTx)
+		require.NoError(t, err)
+
+		// virtualize batch
+		if i <= 6 {
+			b := state.VirtualBatch{BlockNumber: uint64(i), BatchNumber: uint64(i), Coinbase: addr, SequencerAddr: addr, TxHash: hash}
+			err = testState.AddVirtualBatch(ctx, &b, dbTx)
+			require.NoError(t, err)
+		}
+	}
+
+	type testCase struct {
+		name                      string
+		l1SafeBlockNumber         uint64
+		expectedL2SafeBlockNumber uint64
+	}
+
+	testCases := []testCase{
+		{name: "l1 safe block number smaller than block number for the last virtualized batch", l1SafeBlockNumber: 2, expectedL2SafeBlockNumber: 12},
+		{name: "l1 safe block number equal to block number for the last virtualized batch", l1SafeBlockNumber: 6, expectedL2SafeBlockNumber: 16},
+		{name: "l1 safe block number bigger than number for the last virtualized batch", l1SafeBlockNumber: 8, expectedL2SafeBlockNumber: 16},
+	}
+
+	for _, tc := range testCases {
+		t.Run(tc.name, func(t *testing.T) {
+			l2SafeBlockNumber, err := testState.GetSafeL2BlockNumber(ctx, uint64(tc.l1SafeBlockNumber), dbTx)
+			require.NoError(t, err)
+
+			assert.Equal(t, tc.expectedL2SafeBlockNumber, l2SafeBlockNumber)
+		})
+	}
+}
+
+func TestGetFinalizedL2BlockNumber(t *testing.T) {
+	initOrResetDB()
+	ctx := context.Background()
+	dbTx, err := testState.BeginStateTransaction(ctx)
+	require.NoError(t, err)
+	defer func() { require.NoError(t, dbTx.Commit(ctx)) }()
+
+	// prepare data
+	addr := common.HexToAddress("0xf39Fd6e51aad88F6F4ce6aB8827279cffFb92266")
+	hash := common.HexToHash("0x29e885edaf8e4b51e1d2e05f9da28161d2fb4f6b1d53827d9b80a23cf2d7d9f1")
+	for i := 1; i <= 10; i++ {
+		// add l1 block
+		err = testState.AddBlock(ctx, state.NewBlock(uint64(i)), dbTx)
+		require.NoError(t, err)
+
+		// add batch
+		_, err = testState.PostgresStorage.Exec(ctx, "INSERT INTO state.batch (batch_num) VALUES ($1)", i)
+		require.NoError(t, err)
+
+		// add l2 block
+		l2Block := types.NewBlockWithHeader(&types.Header{Number: big.NewInt(int64(i + 10))})
+		err = testState.AddL2Block(ctx, uint64(i), l2Block, []*types.Receipt{}, uint8(0), dbTx)
+		require.NoError(t, err)
+
+		// virtualize batch
+		if i <= 6 {
+			b := state.VirtualBatch{BlockNumber: uint64(i), BatchNumber: uint64(i), Coinbase: addr, SequencerAddr: addr, TxHash: hash}
+			err = testState.AddVirtualBatch(ctx, &b, dbTx)
+			require.NoError(t, err)
+		}
+
+		// verify batch
+		if i <= 3 {
+			b := state.VerifiedBatch{BlockNumber: uint64(i), BatchNumber: uint64(i), TxHash: hash}
+			err = testState.AddVerifiedBatch(ctx, &b, dbTx)
+			require.NoError(t, err)
+		}
+	}
+
+	type testCase struct {
+		name                           string
+		l1FinalizedBlockNumber         uint64
+		expectedL2FinalizedBlockNumber uint64
+	}
+
+	testCases := []testCase{
+		{name: "l1 finalized block number smaller than block number for the last verified batch", l1FinalizedBlockNumber: 1, expectedL2FinalizedBlockNumber: 11},
+		{name: "l1 finalized block number equal to block number for the last verified batch", l1FinalizedBlockNumber: 3, expectedL2FinalizedBlockNumber: 13},
+		{name: "l1 finalized block number bigger than number for the last verified batch", l1FinalizedBlockNumber: 5, expectedL2FinalizedBlockNumber: 13},
+	}
+
+	for _, tc := range testCases {
+		t.Run(tc.name, func(t *testing.T) {
+			l2FinalizedBlockNumber, err := testState.GetFinalizedL2BlockNumber(ctx, uint64(tc.l1FinalizedBlockNumber), dbTx)
+			require.NoError(t, err)
+
+			assert.Equal(t, tc.expectedL2FinalizedBlockNumber, l2FinalizedBlockNumber)
+		})
+	}
+}