Skip to content

Commit

Permalink
bugfix: removing measuring of metrics from async batch reprocessing f… (
Browse files Browse the repository at this point in the history
#2461)

* bugfix: removing measuring of metrics from async batch reprocessing for executor.

Signed-off-by: Nikolay Nedkov <[email protected]>

* fixing unit tests

Signed-off-by: Nikolay Nedkov <[email protected]>

---------

Signed-off-by: Nikolay Nedkov <[email protected]>
  • Loading branch information
Psykepro authored Aug 28, 2023
1 parent f16d9ae commit 307e83e
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
7 changes: 5 additions & 2 deletions sequencer/finalizer.go
Original file line number Diff line number Diff line change
Expand Up @@ -1113,15 +1113,18 @@ func (f *finalizer) reprocessFullBatch(ctx context.Context, batchNum uint64, ini
}

log.Infof("reprocessFullBatch: BatchNumber: %d, OldStateRoot: %s, ExpectedNewStateRoot: %s, GER: %s", batch.BatchNumber, initialStateRoot.String(), expectedNewStateRoot.String(), batch.GlobalExitRoot.String())

caller := stateMetrics.DiscardCallerLabel
if f.cfg.SequentialReprocessFullBatch {
caller = stateMetrics.SequencerCallerLabel
}
processRequest := state.ProcessRequest{
BatchNumber: batch.BatchNumber,
GlobalExitRoot: batch.GlobalExitRoot,
OldStateRoot: initialStateRoot,
Transactions: batch.BatchL2Data,
Coinbase: batch.Coinbase,
Timestamp: batch.Timestamp,
Caller: stateMetrics.SequencerCallerLabel,
Caller: caller,
}

forkID := f.dbManager.GetForkIDByBatchNumber(batchNum)
Expand Down
1 change: 1 addition & 0 deletions sequencer/finalizer_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ var (
},
ResourcePercentageToCloseBatch: 10,
GERFinalityNumberOfBlocks: 64,
SequentialReprocessFullBatch: true,
}
chainID = new(big.Int).SetInt64(400)
pvtKey = "0x28b2b0318721be8c8339199172cd7cc8f5e273800a35616ec893083a4b32c02e"
Expand Down

0 comments on commit 307e83e

Please sign in to comment.